Closed Bug 1372740 Opened 7 years ago Closed 7 years ago

Pin Topsites follow up

Categories

(Firefox for iOS :: Home screen, defect, P1)

Product:
Firefox for iOS
Component:
Home screen
Platform:
Other
iOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Iteration:
1.24
Tracking Flags:
Tracking Status
fxios 8.0+ ---

People

(Reporter: farhan, Assigned: farhan)

References

Details

(Whiteboard: [mobileAS])

Attachments

(2 files)

Pull Request
55 bytes, text/x-github-pull-request
justindarc
: review+
Details | Review
Pull Request
55 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review 
Follow up issues with the Pinning feature in Activity Stream New Tab

 - Allow pinning from History and Bookmarks panel
 - Add a pin icon next to the title for pinned sites
 - Add unpinning of topsites
Blocks: 1370824
Attached file Pull Request — 

        Attachment #8877336 -
        Flags: review?(jdarcangelo)

    
    

    
  
Comment on attachment 8877336 [details] [review]
Pull Request

R+ with comments in the PR.

        Attachment #8877336 -
        Flags: review?(jdarcangelo) → review+

    
    

    
  
master https://github.com/mozilla-mobile/firefox-ios/commit/f0178570f9aadcae5e300757ad460f830d1e4b41
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED

    
  

          tracking-fxios:
          ? → 8.0+
Whiteboard: [mobileAS] → [mobileAS][needsuplift]

    
    

    
  
Uplifted to v8.x
Whiteboard: [mobileAS][needsuplift] → [mobileAS]

    
    

    
  
Pinned tiles only have a prepended bullet in their title. Am I supposed to see a pin image on a tile on top-sites? This is on Firefox Beta.
Flags: needinfo?(fpatel)

    
    

    
  
I'm adding the Pin image in a new PR. Didnt have the icon 3 weeks ago.
Flags: needinfo?(fpatel)

    
    

    
  

      
      
      
      

        Attached file
          
        Pull Request
        — 
      

    


  

        Attachment #8883676 -
        Flags: review?(jdarcangelo)
Whiteboard: [mobileAS] → [mobileAS][needsuplift]

        Attachment #8883676 -
        Flags: review?(jdarcangelo) → review+

    
  
Whiteboard: [mobileAS][needsuplift] → [mobileAS]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: