1372745 - Add a pref for max rows/columns for grid outline to render.

Status: VERIFIED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Micah Tigley [:micah]]

Add a pref for the max number of rows/columns a grid container can contain for the grid outline tool to render.

Comment 1

[Micah Tigley [:micah]]

Attachment: Bug 1372745 - Add a pref for max rows/columns for grid outline to render.

Review commit: https://reviewboard.mozilla.org/r/148694/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148694/

Comment 2

[Micah Tigley [:micah]]

Comment on attachment 8877337 [details]
Bug 1372745 - Add a pref for max rows/columns for grid outline to render.

Cancelling review based on what was discussed earlier.

Comment 3

[Micah Tigley [:micah]]

Attachment: Bug 1372745 - Add a pref for max rows/columns for grid outline to render.

Review commit: https://reviewboard.mozilla.org/r/149642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149642/

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8878306 [details]
Bug 1372745 - Add a pref for max rows/columns for grid outline to render.

https://reviewboard.mozilla.org/r/149642/#review159470

::: devtools/client/inspector/grids/components/GridOutline.js
(Diff revision 1)
>  const { getStr } = require("../utils/l10n");
>  
>  // The delay prior to executing the grid cell highlighting.
>  const GRID_HIGHLIGHTING_DEBOUNCE = 50;
>  
> -// Minimum height/width a grid cell can be

So, I think we should just add the constants here that does the Services.prefs.get for the 2 max col/rows and avoid passing the props down from App.

::: devtools/client/locales/en-US/layout.properties:12
(Diff revision 1)
>  # The Layout Inspector may need to be enabled in about:config by setting
>  # devtools.layoutview.enabled to true.
>  
>  # LOCALIZATION NOTE (layout.cannotShowGridOutline, layout.cannotSHowGridOutline.title):
>  # In the case where the grid outline cannot be effectively displayed.
> -layout.cannotShowGridOutline=Cannot show outline for this grid
> +layout.cannotShowGridOutline=Cannot show outline for this grid. Please check your preferences for the max number of rows and columns the outline can display.

Let's not worry about changing the LOCALIZATION NOTE for now.

Comment 5

[Micah Tigley [:micah]]

Comment on attachment 8878306 [details]
Bug 1372745 - Add a pref for max rows/columns for grid outline to render.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149642/diff/1-2/

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8878306 [details]
Bug 1372745 - Add a pref for max rows/columns for grid outline to render.

https://reviewboard.mozilla.org/r/149642/#review160886

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b97f9164e8d
Add a pref for max rows/columns for grid outline to render. r=gl

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8b97f9164e8d

Comment 9

[Saheda Reza [:Antora]]

This Feature is included on Latest Nightly, It is verified now --
Build ID:    20170712030204
User Agent : Mozilla/5.0 (Windows NT 6.1; rv:56.0) Gecko/20100101 Firefox/56.0

Comment 10

[Saheda Reza [:Antora]]

(In reply to Saheda Reza [:Antora] from comment #9)
> This Feature is included on Latest Nightly, It is verified now --
> Build ID:    20170712030204
> User Agent : Mozilla/5.0 (Windows NT 6.1; rv:56.0) Gecko/20100101
> Firefox/56.0

Tested OS-- Windows7 32bit