1372767 - opus: Enable SSE optimization

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Ralph Giles (:rillian)]

Opus has gained sse 4.1 simd optimizations. We should enable that in our builds.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1372767 - opus: enable SSE simd optimization.

Opus now has SSE and SSE 4.1 optimizations. Enable these
in our build by adding the extra source files and defines.

Review commit: https://reviewboard.mozilla.org/r/148756/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148756/

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 8877367 [details]
Bug 1372767 - opus: enable SSE simd optimization.

https://reviewboard.mozilla.org/r/148756/#review153194

::: media/libopus/moz.build:89
(Diff revision 1)
>      ]
>      UNIFIED_SOURCES += silk_sources_fixed
> -# for webrtc
> -    UNIFIED_SOURCES += opus_sources_float
>  
> +if CONFIG['CPU_ARCH'] in ('x86', '86_64'):

86_64 should be x86_64 I assume

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8877367 [details]
Bug 1372767 - opus: enable SSE simd optimization.

https://reviewboard.mozilla.org/r/148756/#review153566

::: media/libopus/moz.build:89
(Diff revision 1)
>      ]
>      UNIFIED_SOURCES += silk_sources_fixed
> -# for webrtc
> -    UNIFIED_SOURCES += opus_sources_float
>  
> +if CONFIG['CPU_ARCH'] in ('x86', '86_64'):

Indeed it should! Thanks. I thought that went a little too smoothly...

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 8877367 [details]
Bug 1372767 - opus: enable SSE simd optimization.

https://reviewboard.mozilla.org/r/148756/#review153596

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8877367 [details]
Bug 1372767 - opus: enable SSE simd optimization.

https://reviewboard.mozilla.org/r/148756/#review153636

::: media/libopus/moz.build:95
(Diff revision 1)
> +    DEFINES['OPUS_HAVE_RTCD'] = True
> +    DEFINES['OPUS_X86_MAY_HAVE_SSE'] = True
> +    DEFINES['OPUS_X86_MAY_HAVE_SSE2'] = True
> +    DEFINES['OPUS_X86_MAY_HAVE_SSE4_1'] = True
> +    DEFINES['OPUS_X86_MAY_HAVE_AVX'] = True
> +    UNIFIED_SOURCES += celt_sources_sse

i686-linux still builds with -mmmx by default so we need to set -msse for these files.

::: media/libopus/moz.build:105
(Diff revision 1)
> +    else:
> +        UNIFIED_SOURCES += silk_sources_fixed_sse4_1
> +    if not CONFIG['_MSC_VER'] or CONFIG['CLANG_CL']:
> +        for f in UNIFIED_SOURCES:
> +            if f in celt_sources_sse2:
> +                UNIFIED_SOURCES[f].flags += CONFIG['SSE2_FLAGS']

I think we have to use `SOURCES` here to attach individual tags.

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8877367 [details]
Bug 1372767 - opus: enable SSE simd optimization.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148756/diff/1-2/

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8877367 [details]
Bug 1372767 - opus: enable SSE simd optimization.

https://reviewboard.mozilla.org/r/148756/#review153666

Updated to address issues from try.

Comment 8

[Ralph Giles (:rillian)]

Comment on attachment 8877367 [details]
Bug 1372767 - opus: enable SSE simd optimization.

https://reviewboard.mozilla.org/r/148756/#review154076

::: media/libopus/moz.build:99
(Diff revision 2)
> +    DEFINES['OPUS_X86_MAY_HAVE_AVX'] = True
> +    SOURCES += celt_sources_sse
> +    SOURCES += celt_sources_sse2
> +    SOURCES += celt_sources_sse4_1
> +    if CONFIG['MOZ_SAMPLE_TYPE_FLOAT32']:
> +        SOURCES += silk_sources_sse4_1

Turns out `silk_sources_sse4_1` should be included unconditionally; it's shared between the fixed and float variants. Only `silk_sources_fixed_sse4_1` needs a conditional here.

Comment 9

[Ralph Giles (:rillian)]

Comment on attachment 8877367 [details]
Bug 1372767 - opus: enable SSE simd optimization.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148756/diff/2-3/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4175246fd7a1
opus: enable SSE simd optimization. r=kinetik,ted

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4175246fd7a1

Comment 12

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

one compiler warning alert (for information only, no action required):
== Change summary for alert #7335 (as of June 15 2017 19:53 UTC) ==

Regressions:

  3%  compiler warnings summary osx-10-7-noopt debug      6,542.33 -> 6,770.83

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7335