Closed
Bug 1372790
Opened 7 years ago
Closed 7 years ago
Reorder single-byte fields slightly to save some size of StyleSheet
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → xidorn+moz
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 2•7 years ago
|
||
Those fields can actually be just bitfields. But changing them to bitfields doesn't have any extra benefit for now.
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8877409 [details] Bug 1372790 - Change uint8_t to back some enum and reorder some fields in StyleSheet to make it more compact. https://reviewboard.mozilla.org/r/148808/#review153274 You'll probably have to update the constructors to swap the initialization order around to avoid compiler warnings.
Attachment #8877409 -
Flags: review?(cam) → review+
| Comment hidden (mozreview-request) |
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a5fe1b7f3dad Change uint8_t to back some enum and reorder some fields in StyleSheet to make it more compact. r=heycam
|
||
Comment 6•7 years ago
|
||
Too compact! Backed out in https://hg.mozilla.org/integration/autoland/rev/740241e9c9a5 for https://treeherder.mozilla.org/logviewer.html#?job_id=106904195&repo=autoland
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 9•7 years ago
|
||
Comment on attachment 8877409 [details] Bug 1372790 - Change uint8_t to back some enum and reorder some fields in StyleSheet to make it more compact. Try run looks good now. Change parser code to not use bit field for mParsingMode, and include stdint.h in SheetParsingMode.h.
Attachment #8877409 -
Flags: review+ → review?(cam)
|
|
||
Updated•7 years ago
|
Attachment #8877409 -
Flags: review?(cam) → review+
|
||
Comment 10•7 years ago
|
||
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/39a4fd732ab8 Change uint8_t to back some enum and reorder some fields in StyleSheet to make it more compact. r=heycam
|
||
Comment 11•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/39a4fd732ab8
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•