1372863 - Fix dump messages of frame tree for preserves-3d

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Thinker Li [:sinker]]

Attachment: fix-frame-tree-dump.diff

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170520172551

Steps to reproduce:

For frames with the |true| value returned by |Extend3DContext()|, their transform style is preserve-3d. For frames with the |true| value returned by |Combine3DTransformWithAncestor()|, their parents are with the transform style of preserve-3d.  So, wording in the dump of frame tree should be |preserves-3d| for |Extend3DContext()| and |preserves-3d-child| for |Combine3DTransformWithAncestor()|, but is opposite in fact.

Comment 1

[Thinker Li [:sinker]]

Comment on attachment 8877531 [details] [diff] [review]
fix-frame-tree-dump.diff

Hi Matt,
How do you think about the wording here?

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8877531 [details] [diff] [review]
fix-frame-tree-dump.diff

Review of attachment 8877531 [details] [diff] [review]:
-----------------------------------------------------------------

Should we just use 'extend-3d' and 'combines-3d-transform-with-ancestors'?

I think that's clearer, and it'll be easier to match up to the code.

Comment 3

[Thinker Li [:sinker]]

Attachment: fix-frame-tree-dump.diff, v2

Change words the same as suggestions above.

Comment 4

[Thinker Li [:sinker]]

Attachment: Fix dump message of frame tree for preserves-3d, v3

r=mattwoodrow

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4377cf67ad41
Fix dump message of frame tree for preserves-3d. r=mattwoodrow

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4377cf67ad41