Closed
Bug 1372863
Opened 7 years ago
Closed 7 years ago
Fix dump messages of frame tree for preserves-3d
Categories
(Core :: Layout: Block and Inline, defect)
Core
Layout: Block and Inline
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: sinker, Assigned: sinker)
Details
Attachments
(1 file, 2 obsolete files)
1.11 KB,
patch
|
sinker
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 Build ID: 20170520172551 Steps to reproduce: For frames with the |true| value returned by |Extend3DContext()|, their transform style is preserve-3d. For frames with the |true| value returned by |Combine3DTransformWithAncestor()|, their parents are with the transform style of preserve-3d. So, wording in the dump of frame tree should be |preserves-3d| for |Extend3DContext()| and |preserves-3d-child| for |Combine3DTransformWithAncestor()|, but is opposite in fact.
Assignee | ||
Comment 1•7 years ago
|
||
Comment on attachment 8877531 [details] [diff] [review] fix-frame-tree-dump.diff Hi Matt, How do you think about the wording here?
Attachment #8877531 -
Flags: review?(matt.woodrow)
Comment 2•7 years ago
|
||
Comment on attachment 8877531 [details] [diff] [review] fix-frame-tree-dump.diff Review of attachment 8877531 [details] [diff] [review]: ----------------------------------------------------------------- Should we just use 'extend-3d' and 'combines-3d-transform-with-ancestors'? I think that's clearer, and it'll be easier to match up to the code.
Assignee | ||
Comment 3•7 years ago
|
||
Change words the same as suggestions above.
Attachment #8877531 -
Attachment is obsolete: true
Attachment #8877531 -
Flags: review?(matt.woodrow)
Attachment #8877984 -
Flags: review?(matt.woodrow)
Updated•7 years ago
|
Attachment #8877984 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 4•7 years ago
|
||
r=mattwoodrow
Attachment #8877984 -
Attachment is obsolete: true
Attachment #8879913 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Updated•7 years ago
|
Assignee: nobody → thinker.li
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4377cf67ad41 Fix dump message of frame tree for preserves-3d. r=mattwoodrow
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4377cf67ad41
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•