HashTable::AddPtr's mutation count is not checked

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

55 Branch
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
HashTable::AddPtr has a mutation count which is presumably there so we can check that the table has not changed since lookupForAdd was called, but this check is missing.
(Assignee)

Comment 1

a year ago
Created attachment 8877609 [details] [diff] [review]
bug1372875-hashtable-checks

Patch to check generation and mutation count in HashTable:add and generation in remove and rekeyWithoutRehash methods.  Also increment generation when hash table is rehashed in place.

None of these asserts failed in a try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7501bac95a0aac586212c11f502be790e285d979&selectedJob=107008453
Attachment #8877609 - Flags: review?(luke)

Updated

a year ago
Attachment #8877609 - Flags: review?(luke) → review+

Comment 2

a year ago
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f71a1645c218
Add more assertions for hash table pointer generation and mutation count r=luke

Comment 3

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f71a1645c218
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.