Closed
Bug 1372875
Opened 8 years ago
Closed 8 years ago
HashTable::AddPtr's mutation count is not checked
Categories
(Core :: JavaScript Engine, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
2.65 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
HashTable::AddPtr has a mutation count which is presumably there so we can check that the table has not changed since lookupForAdd was called, but this check is missing.
|
Assignee | |
Comment 1•8 years ago
|
||
Patch to check generation and mutation count in HashTable:add and generation in remove and rekeyWithoutRehash methods. Also increment generation when hash table is rehashed in place.
None of these asserts failed in a try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7501bac95a0aac586212c11f502be790e285d979&selectedJob=107008453
Attachment #8877609 -
Flags: review?(luke)
|
||
Updated•8 years ago
|
Attachment #8877609 -
Flags: review?(luke) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f71a1645c218
Add more assertions for hash table pointer generation and mutation count r=luke
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•