1372886 - Remove the dead fourth parameter from nsIConverterOutputStream::init

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Description

[Masatoshi Kimura [:emk]]

We can safely remove this because this is the last parameter. We already made this parameter non-functional (bug 819869).

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1372886 - Remove dead parameters from nsIConverterInputStream.init().

Review commit: https://reviewboard.mozilla.org/r/150082/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150082/

Comment 2

[Henri Sivonen (:hsivonen)]

Is this safe before 57 removing support for XPCOM extensions?

Comment 3

[Masatoshi Kimura [:emk]]

(In reply to Henri Sivonen (:hsivonen) from comment #2)
> Is this safe before 57 removing support for XPCOM extensions?

XPCOM functions will accept (and ignore) extra parameters. The third and fourth parameters are already have no effect. So I believe it is safe to remove them. (We don't even have to fix callers, but I did it for completeness.)

Comment 4

[Henri Sivonen (:hsivonen)]

Comment on attachment 8878776 [details]
Bug 1372886 - Remove dead parameters from nsIConverterInputStream.init().

https://reviewboard.mozilla.org/r/150082/#review154772

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d3a33cee35a
Remove dead parameters from nsIConverterInputStream.init(). r=hsivonen

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4d3a33cee35a

Comment 7

[Jorg K (CEST = GMT+2)]

Why does the summary and the commit message mention nsIConverterInputStream when you're removing parameters of nsIConverterOutputStream?
https://hg.mozilla.org/mozilla-central/rev/4d3a33cee35a#l22.2

Comment 8

[Masatoshi Kimura [:emk]]

Oops, sorry, I missed the summary.

Comment 9

[Jorg K (CEST = GMT+2)]

I just wanted to make sure that I'm doing the right thing in attachment 8878926 [details] [diff] [review].

Will there be changes made to nsIConverterInputStream as well? Bug 819869 quoted in comment #0 is about nsIConverterInputStream.

Comment 10

[Jorg K (CEST = GMT+2)]

In fact, looking at nsConverterInputStream::Init, all four parameters are used.