Closed Bug 1372886 Opened 2 years ago Closed 2 years ago

Remove the dead fourth parameter from nsIConverterOutputStream::init

Categories

(Core :: Internationalization, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(1 file)

We can safely remove this because this is the last parameter. We already made this parameter non-functional (bug 819869).
Is this safe before 57 removing support for XPCOM extensions?
(In reply to Henri Sivonen (:hsivonen) from comment #2)
> Is this safe before 57 removing support for XPCOM extensions?

XPCOM functions will accept (and ignore) extra parameters. The third and fourth parameters are already have no effect. So I believe it is safe to remove them. (We don't even have to fix callers, but I did it for completeness.)
Comment on attachment 8878776 [details]
Bug 1372886 - Remove dead parameters from nsIConverterInputStream.init().

https://reviewboard.mozilla.org/r/150082/#review154772
Attachment #8878776 - Flags: review?(hsivonen) → review+
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/4d3a33cee35a
Remove dead parameters from nsIConverterInputStream.init(). r=hsivonen
https://hg.mozilla.org/mozilla-central/rev/4d3a33cee35a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Why does the summary and the commit message mention nsIConverterInputStream when you're removing parameters of nsIConverterOutputStream?
https://hg.mozilla.org/mozilla-central/rev/4d3a33cee35a#l22.2
Oops, sorry, I missed the summary.
Summary: Remove the dead fourth parameter from nsIConverterInputStream::init → Remove the dead fourth parameter from nsIConverterOutputStream::init
I just wanted to make sure that I'm doing the right thing in attachment 8878926 [details] [diff] [review].

Will there be changes made to nsIConverterInputStream as well? Bug 819869 quoted in comment #0 is about nsIConverterInputStream.
In fact, looking at nsConverterInputStream::Init, all four parameters are used.
You need to log in before you can comment on or make changes to this bug.