Closed
Bug 1372892
Opened 7 years ago
Closed 7 years ago
Make tasks that do not have any *new* dependencies depend on the decision task
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla56
People
(Reporter: dustin, Assigned: dustin)
References
Details
Attachments
(1 file)
Currently, if you have, say, a build task that depends on a docker-image task, it will not be made to depend on the decision task. The idea is that the docker-images task must depend on the decision task, but that's not the case when that docker-image task was optimized to point to an older, complete task.
Assignee | ||
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec160d6cd9fe27bf5d110f7c55d9dad370ec220c
Assignee | ||
Comment 3•7 years ago
|
||
https://tools.taskcluster.net/groups/DrDADzdgRj2BT-6-t3W-Jg/tasks/efQld-59RLiha0aywZ0zyQ/details in particular shows this patch in action.
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8883035 [details] Bug 1372892: make tasks with optimized dependencies depend on decision task; https://reviewboard.mozilla.org/r/153992/#review159592
Attachment #8883035 -
Flags: review?(bugspam.Callek) → review+
Pushed by dmitchell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2f3454d832c6 make tasks with optimized dependencies depend on decision task; r=Callek
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2f3454d832c6
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment 8•7 years ago
|
||
backed out for causing bug 1378744
Status: RESOLVED → REOPENED
Flags: needinfo?(dustin)
Resolution: FIXED → ---
Backout by cbook@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/4bd7db49d228 Backed out changeset 2f3454d832c6 for breaking nightly signing - causing bug 1378744
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(dustin)
Assignee | ||
Comment 10•7 years ago
|
||
Bug 1378744 being fixed, I think we can re-land this. But since it hit nightlies, I'll wait until next week instead of doing it over the weekend.
Assignee | ||
Comment 11•7 years ago
|
||
..going to hold off on this a bit longer -- I landed some changes to use JSON-e in .taskcluster.yml which may also affect nightlies, and that hasn't gotten to central yet. Also, there's the big Windows reveal coming up later this week.
Assignee | ||
Comment 12•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf3ae82e04e69085be7f226b88917f3f36e0677b Bug 1372892: make tasks with optimized dependencies depend on decision task; r=aki
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bf3ae82e04e6
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•