Closed
Bug 1372962
Opened 7 years ago
Closed 7 years ago
Use nsIServiceWorker idl defined state constants in test_devtools_track_serviceworker_time.html
Categories
(Core :: DOM: Service Workers, enhancement)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file)
Currently test_devtools_track_serviceworker_time.html hard codes the state enumeration integers. It should use the constants as defined in the idl file instead. I'm changing the state constants slightly in bug 1293277, so I need this there.
|
Assignee | |
Comment 1•7 years ago
|
||
Tom, this patch replaces the integer values in test_devtools_track_serviceworker_time.html with the constants defined in nsIServiceWorkerManager.idl. This just makes the test a bit more resilient if we change the constants at all.
Attachment #8877665 -
Flags: review?(ttung)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8877665 [details] [diff] [review] Use idl defined state constants in test_devtools_track_serviceworker_time.html. r=tt Review of attachment 8877665 [details] [diff] [review]: ----------------------------------------------------------------- LGTM! I should get these values from IDL file rather than set magic numbers. It makes the original test more flexible. Thanks!
Attachment #8877665 -
Flags: review?(ttung) → review+
Pushed by bkelly@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f7c293dd57aa Use idl defined state constants in test_devtools_track_serviceworker_time.html. r=tt
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f7c293dd57aa
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•