Closed
Bug 1372969
Opened 7 years ago
Closed 7 years ago
Use a different string ID for Window_ControllersWarning in dom.properties to reflect new content
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: flod, Assigned: peterv)
References
Details
Attachments
(1 file)
4.87 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
https://hg.mozilla.org/mozilla-central/diff/a358c0a7c665/dom/locales/en-US/chrome/dom/dom.properties String changed keeping the existing ID -Window_ControllersWarning=window.controllers is deprecated. Do not use it for UA detection. +Window_ControllersWarning=window.controllers/Controllers is deprecated. Do not use it for UA detection. The only way to make sure all languages update that string is to use a different string ID.
Comment 1•7 years ago
|
||
Peter, can you take this as a followup to bug 1252211?
Flags: needinfo?(peterv)
Priority: -- → P2
Assignee | ||
Comment 2•7 years ago
|
||
Assignee: nobody → peterv
Status: NEW → ASSIGNED
Flags: needinfo?(peterv)
Attachment #8884199 -
Flags: review?(bugs)
Comment 3•7 years ago
|
||
Comment on attachment 8884199 [details] [diff] [review] v1 eWindow_Cc_ontrollers looks unusual, but I guess makes sense here.
Attachment #8884199 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 5•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a06c1daddacd43ac6dd084e1c4110ac26e7ae262 Bug 1372969 - Use a different string ID for Window_ControllersWarning in dom.properties to reflect new content.
Pushed by pvanderbeken@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a06c1daddacd Use a different string ID for Window_ControllersWarning in dom.properties to reflect new content.
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a06c1daddacd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(peterv)
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•