Closed Bug 1372969 Opened 2 years ago Closed 2 years ago

Use a different string ID for Window_ControllersWarning in dom.properties to reflect new content

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: flod, Assigned: peterv)

References

Details

Attachments

(1 file)

https://hg.mozilla.org/mozilla-central/diff/a358c0a7c665/dom/locales/en-US/chrome/dom/dom.properties

String changed keeping the existing ID

-Window_ControllersWarning=window.controllers is deprecated. Do not use it for UA detection.
+Window_ControllersWarning=window.controllers/Controllers is deprecated. Do not use it for UA detection.

The only way to make sure all languages update that string is to use a different string ID.
Peter, can you take this as a followup to bug 1252211?
Flags: needinfo?(peterv)
Priority: -- → P2
Attached patch v1Splinter Review
Assignee: nobody → peterv
Status: NEW → ASSIGNED
Flags: needinfo?(peterv)
Attachment #8884199 - Flags: review?(bugs)
Comment on attachment 8884199 [details] [diff] [review]
v1

eWindow_Cc_ontrollers looks unusual, but I guess makes sense here.
Attachment #8884199 - Flags: review?(bugs) → review+
Anything blocking this from landing?
Flags: needinfo?(peterv)
https://hg.mozilla.org/integration/mozilla-inbound/rev/a06c1daddacd43ac6dd084e1c4110ac26e7ae262
Bug 1372969 - Use a different string ID for Window_ControllersWarning in dom.properties to reflect new content.
Pushed by pvanderbeken@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a06c1daddacd
Use a different string ID for Window_ControllersWarning in dom.properties to reflect new content.
https://hg.mozilla.org/mozilla-central/rev/a06c1daddacd
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Flags: needinfo?(peterv)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.