WebGL 1.04 extensions/webgl-draw-buffers-framebuffer-unsupported

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: svargas, Assigned: svargas)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(2 attachments, 5 obsolete attachments)

(Assignee)

Description

a year ago
https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/webgl-draw-buffers-framebuffer-unsupported.html?webglVersion=1&quiet=0

^ Fails because PrecheckBufferStatus doesn't ensure that the same texImageTarget and WebGLTexture aren't bound to multiple attachments at once.
(Assignee)

Comment 1

a year ago
Created attachment 8877710 [details] [diff] [review]
0001-Bug-1373007-WebGL-1.04-extensions-webgl-draw-buffers.patch
Assignee: nobody → svargas
Attachment #8877710 - Flags: review?(jgilbert)
(Assignee)

Comment 3

a year ago
Created attachment 8877803 [details] [diff] [review]
0001-Bug-1373007-WebGL-1.04-extensions-webgl-draw-buffers.patch

Reduced complexity and improved correctness of attachment duplication checking.
Attachment #8877710 - Attachment is obsolete: true
Attachment #8877710 - Flags: review?(jgilbert)
Attachment #8877803 - Flags: review?(jgilbert)
(Assignee)

Comment 4

a year ago
Created attachment 8877818 [details] [diff] [review]
0001-Bug-1372438-STENCIL_INDEX-is-not-a-WebGL-constant-r-.patch

I updated the patch to remove STENCIL_INDEX references from the tests following the same pattern as this commit:

https://github.com/KhronosGroup/WebGL/commit/7ad77d73fd904695b2851827692e58b30b568a41


https://treeherder.mozilla.org/#/jobs?repo=try&revision=09e6818996435f11cd9f33adb672240303578d4c
Attachment #8877803 - Attachment is obsolete: true
Attachment #8877803 - Flags: review?(jgilbert)
Attachment #8877818 - Flags: review?(jgilbert)
(Assignee)

Comment 5

a year ago
Created attachment 8877821 [details] [diff] [review]
0001-Bug-1373007-WebGL-1.04-extensions-webgl-draw-buffers.patch

Disregard previous comment, wrong bug!
Attachment #8877818 - Attachment is obsolete: true
Attachment #8877818 - Flags: review?(jgilbert)
(Assignee)

Comment 8

a year ago
Forgot to upload from the correct git worktree (unrelated patch was also applied):

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5dacc92e1c1be0e16fd9ddfc7ba95fa89655c68
(Assignee)

Comment 9

a year ago
Created attachment 8878708 [details] [diff] [review]
0001-Bug-1373007-WebGL-1.04-extensions-webgl-draw-buffers.patch

https://hg.mozilla.org/try/rev/ad2606c9520be446c540c8ea1da2a32ddfd7672e
Attachment #8877821 - Attachment is obsolete: true
Attachment #8878708 - Flags: review?(jgilbert)
Comment on attachment 8878708 [details] [diff] [review]
0001-Bug-1373007-WebGL-1.04-extensions-webgl-draw-buffers.patch

Review of attachment 8878708 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLFramebuffer.cpp
@@ +743,5 @@
> +WebGLFramebuffer::HasDuplicateAttachments() const
> +{
> +   std::set<WebGLFBAttachPoint::Ordered> uniqueAttachSet;
> +
> +   for (auto& attach : mColorAttachments) {

const auto&

@@ +870,5 @@
>      if (!AllImageSamplesMatch())
>          return LOCAL_GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE; // Inconsistent samples
>  
> +    if (HasDuplicateAttachments()) {
> +       return LOCAL_GL_FRAMEBUFFER_UNSUPPORTED;

No {} around the return here.
Attachment #8878708 - Flags: review?(jgilbert) → review+
(Assignee)

Comment 11

a year ago
Created attachment 8878710 [details] [diff] [review]
0001-Bug-1373007-WebGL-1.04-extensions-webgl-draw-buffers.patch

Fixed const auto& and {}
Attachment #8878708 - Attachment is obsolete: true
Attachment #8878710 - Flags: review+

Comment 12

a year ago
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/730c95f8ee15
WebGL 1.04 extensions/webgl-draw-buffers-framebuffer-unsupported - r=jgilbert
Created attachment 8880574 [details] [diff] [review]
0001-Bug-1373007-Update-test-markings.patch
Backed both out in https://hg.mozilla.org/integration/mozilla-inbound/rev/ebb13a988e04 for failing to mark the new passes on OS X in test_2_conformance2__rendering__framebuffer-unsupported.html and test_2_conformance__textures__misc__tex-image-with-format-and-type.html, https://treeherder.mozilla.org/logviewer.html#?job_id=109391736&repo=mozilla-inbound and https://treeherder.mozilla.org/logviewer.html#?job_id=109391787&repo=mozilla-inbound
Oh, test_2_conformance__textures__misc__tex-image-with-format-and-type.html isn't this, it's bug 1372385 and I need one more backout.
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 17

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94a26629a933
WebGL 1.04 extensions/webgl-draw-buffers-framebuffer-unsupported. r=jgilbert
Keywords: checkin-needed

Comment 19

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/94a26629a933
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.