1373007 - WebGL 1.04 extensions/webgl-draw-buffers-framebuffer-unsupported

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement)

Description

[Samuel Vargas [:svargas]]

https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/webgl-draw-buffers-framebuffer-unsupported.html?webglVersion=1&quiet=0

^ Fails because PrecheckBufferStatus doesn't ensure that the same texImageTarget and WebGLTexture aren't bound to multiple attachments at once.

Comment 1

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1373007-WebGL-1.04-extensions-webgl-draw-buffers.patch

Comment 2

[Samuel Vargas [:svargas]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e2dec29bd727eab9e80c01168a1eb0abc21aea9

Comment 3

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1373007-WebGL-1.04-extensions-webgl-draw-buffers.patch

Reduced complexity and improved correctness of attachment duplication checking.

Comment 4

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1372438-STENCIL_INDEX-is-not-a-WebGL-constant-r-.patch

I updated the patch to remove STENCIL_INDEX references from the tests following the same pattern as this commit:

https://github.com/KhronosGroup/WebGL/commit/7ad77d73fd904695b2851827692e58b30b568a41


https://treeherder.mozilla.org/#/jobs?repo=try&revision=09e6818996435f11cd9f33adb672240303578d4c

Comment 5

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1373007-WebGL-1.04-extensions-webgl-draw-buffers.patch

Disregard previous comment, wrong bug!

Comment 6

[Samuel Vargas [:svargas]]

New try to reflect new patch:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c86e49938ac8eca255fae2b58ae1c473bc156fc

Comment 7

[Samuel Vargas [:svargas]]

Forgot to specify mochitest-gl in TryChooser:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=19d88ac7d74cc6fea2dc94e538625d59eb71c83c

Comment 8

[Samuel Vargas [:svargas]]

Forgot to upload from the correct git worktree (unrelated patch was also applied):

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5dacc92e1c1be0e16fd9ddfc7ba95fa89655c68

Comment 9

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1373007-WebGL-1.04-extensions-webgl-draw-buffers.patch

https://hg.mozilla.org/try/rev/ad2606c9520be446c540c8ea1da2a32ddfd7672e

Comment 10

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8878708 [details] [diff] [review]
0001-Bug-1373007-WebGL-1.04-extensions-webgl-draw-buffers.patch

Review of attachment 8878708 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLFramebuffer.cpp
@@ +743,5 @@
> +WebGLFramebuffer::HasDuplicateAttachments() const
> +{
> +   std::set<WebGLFBAttachPoint::Ordered> uniqueAttachSet;
> +
> +   for (auto& attach : mColorAttachments) {

const auto&

@@ +870,5 @@
>      if (!AllImageSamplesMatch())
>          return LOCAL_GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE; // Inconsistent samples
>  
> +    if (HasDuplicateAttachments()) {
> +       return LOCAL_GL_FRAMEBUFFER_UNSUPPORTED;

No {} around the return here.

Comment 11

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1373007-WebGL-1.04-extensions-webgl-draw-buffers.patch

Fixed const auto& and {}

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/730c95f8ee15
WebGL 1.04 extensions/webgl-draw-buffers-framebuffer-unsupported - r=jgilbert

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/667c5d2b3f77
Update test markings.

Comment 14

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Bug-1373007-Update-test-markings.patch

Comment 15

[Phil Ringnalda (:philor)]

Backed both out in https://hg.mozilla.org/integration/mozilla-inbound/rev/ebb13a988e04 for failing to mark the new passes on OS X in test_2_conformance2__rendering__framebuffer-unsupported.html and test_2_conformance__textures__misc__tex-image-with-format-and-type.html, https://treeherder.mozilla.org/logviewer.html#?job_id=109391736&repo=mozilla-inbound and https://treeherder.mozilla.org/logviewer.html#?job_id=109391787&repo=mozilla-inbound

Comment 16

[Phil Ringnalda (:philor)]

Oh, test_2_conformance__textures__misc__tex-image-with-format-and-type.html isn't this, it's bug 1372385 and I need one more backout.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94a26629a933
WebGL 1.04 extensions/webgl-draw-buffers-framebuffer-unsupported. r=jgilbert

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/992a8358d408
More manifest fixups. a=me

Comment 19

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/mozilla-central/rev/94a26629a933