1373008 - Save errorsummary.log "group" value with failure_lines

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Data Ingestion, enhancement)

Description

[Cameron Dawson [:camd]]

A new "group" field has been added to the "*errorsummary.log" files by ahal.  This is often the manifest, but can be something else.  We should preserve this alongside the error_lines they apply to.

This allows us to then download that information in the Test Group UI through its GraphQL call.  Then the Test Group UI doesn't have to download the *errorsummary.log files itself and parse them.  

At the same time we fix the ingestion, we should update the GraphQL schema to allow downloading that test "group".

Note: This is not to be confused with the "JobGroup" that jobs are placed in.  They are totally separate.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:manifest-errorlines > mozilla:master

Comment 2

[Cameron Dawson [:camd]]

Comment on attachment 8878262 [details] [review]
[treeherder] mozilla:manifest-errorlines > mozilla:master

Hi James-- Would you mind reviewing this?  It's mostly near your code.  The part for GraphQL is pretty trivial, so I'm sure it'll be fairly obvious.

I've already tested this implementation locally and it works well for the needs of the Test Group Based UI.

Thanks!  :)

Comment 3

[Cameron Dawson [:camd]]

Comment on attachment 8878262 [details] [review]
[treeherder] mozilla:manifest-errorlines > mozilla:master

I made some changes.  Please enjoy them at your leisure, sir.

Comment 4

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e181d21989bed47f49d43f87837126662b97896b
Bug 1373008 - Store test group for FailureLines as a many-to-many relationship

Test Group is often a manifest, but not necessarily.  It could be just
``default`` when there is no manifest.

https://github.com/mozilla/treeherder/commit/e42aa326236b162be6f05bbed1ffee86c43c81f7
Bug 1373008 - Add support for getting the FailureLine Group via GraphQL