1373070 - Incomplete symbolification of Rust panic stack

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Andrew McCreight [:mccr8]]

This bug was filed from the Socorro interface and is 
report bp-48c58b42-e2d2-49c1-be54-5040b0170614.
=============================================================

This Rust panic is showing up on Linux with this bad signature. (The bug for the actual crash is bug 1372994.) Ted, could you look into why we're not getting proper symbols on Linux for this?

Note that most of the stack is fine. It only the top two frames above std::panicking::rust_panic that are bad.

Comment 1

[Andrew McCreight [:mccr8]]

Also, it seems to be okay at least sometimes on Linux:
  bp-838a1b01-8b3a-4293-925f-f8e550170614
That's a different crash, but also a Rust panic, from the same Nightly, that does have the right top two frames.

Comment 2

[Henri Sivonen (:hsivonen)]

See also bug 1360497 and https://internals.rust-lang.org/t/stack-trace-friendly-debug-info-for-macros/5370 .

Comment 3

[(not currently active) Ted Mielczarek]

I note that the crash report in comment 0 shows "firefox-bin" as the binary name in the modules list / in the stack frames, and the crash report in comment 1 shows just "firefox". I bet we just stopped dumping symbols for `firefox-bin` in bug 1337986.

Previously we'd dump symbols from everything in $(DIST)/bin that looked like a binary file. Now we dump symbols from binaries as part of the build, and the -bin isn't actually built as a binary, it's just copied in a Makefile rule:
https://dxr.mozilla.org/mozilla-central/rev/fe809f57bf2287bb937c3422ed03a63740b3448b/browser/app/Makefile.in#51

Comment 4

[Mike Hommey [:glandium]]

The sad part is that this confirms that people are still launching firefox through firefox-bin :(

Comment 5

[Gregory Szorc [:gps]]

Mass needinfo'ing build peers touching compiled code who aren't on vacation...

Is this still an issue? If so, could you please set the firefox 57 tracking flag?

(Please clear other needinfos whoever triages this first.)

Comment 6

[Andrew McCreight [:mccr8]]

I see a few recent instances of crashes with firefox-bin on the top, like bp-c26e5ce7-4462-4374-b90b-35d8e0170922 but they don't involve Rust. Maybe this is just a general problem (though rare) and only incidentally involved Rust in the crash I saw.

Comment 7

[(not currently active) Ted Mielczarek]

This is just a quirk of someone launching the binary as `firefox-bin`. The stack is fine, we just aren't properly symbolicating those frames when the binary has that name.