1373096 - js/xpconnect/src/XPCComponents.cpp:2506:22: error: unused variable 'flatLocation'

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Jan Beich]

1. Build on a Tier3 [1] platform or edit gecko_profiler() to return False
2. Add to "ac_add_options --enable-warnings-as-errors" to .mozconfig
3. ./mach build (use Clang)
[...]
In file included from js/xpconnect/src/Unified_cpp_js_xpconnect_src0.cpp:29:
js/xpconnect/src/XPCComponents.cpp:2506:22: error: unused variable 'flatLocation'
      [-Werror,-Wunused-variable]
    const nsCString& flatLocation = PromiseFlatCString(registryLocation);
                     ^
1 error generated.

[1] GeckProfiler is a (incomplete) stub on iOS, Linux non-x86, BSDs, Solaris, Darwin/X11.

Comment 1

[Jan Beich]

(In reply to Jan Beich from comment #0)
> 1. ... or edit gecko_profiler() to return False

in http://searchfox.org/mozilla-central/rev/c49a70b53f67/toolkit/moz.configure#39
This is a temporary workaround until bug 1371159 where --enable-warnings-as-errors may be covered by MOZ_AUTOMATION.

Comment 2

[Jan Beich]

Attachment: Bug 1373096 - Unbreak --enable-warnings-as-errors build without GeckoProfiler after bug 1372901.

Review commit: https://reviewboard.mozilla.org/r/149264/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149264/

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8877837 [details]
Bug 1373096 - Unbreak --enable-warnings-as-errors build without GeckoProfiler after bug 1372901.

https://reviewboard.mozilla.org/r/149264/#review153756

One of these days I'll remember to think of this...

Comment 4

[Jan Beich]

Push to inbound unless bug 1372901 is merged to central (and autoland) by that time.

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 9ee7dd73d9a8 -d bc85129e5c3e: rebasing 401979:9ee7dd73d9a8 "Bug 1373096 - Unbreak --enable-warnings-as-errors build without GeckoProfiler after bug 1372901. r=mstange" (tip)
merging js/xpconnect/src/XPCComponents.cpp
warning: conflicts while merging js/xpconnect/src/XPCComponents.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/610b983f605e
Unbreak --enable-warnings-as-errors build without GeckoProfiler after bug 1372901. r=mstange

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/610b983f605e