1373121 - about:url-classifier: Support get back-off time

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement, P3)

Description

[Dimi Lee [:dimi]]

In bug 1369290, we suspect that this is related to back-off time.
But we don't have a good way to verify it, add back-off time in about:url-classifier seems a good idea.

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1373121 - about:url-classifier: Support get back-off time.

Review commit: https://reviewboard.mozilla.org/r/149288/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149288/

Comment 2

[Dimi Lee [:dimi]]

Comment on attachment 8877866 [details]
Bug 1373121 - about:url-classifier: Support get back-off time.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149288/diff/1-2/

Comment 3

[François Marier [:francois]]

Comment on attachment 8877866 [details]
Bug 1373121 - about:url-classifier: Support get back-off time.

https://reviewboard.mozilla.org/r/149288/#review153766

::: toolkit/components/url-classifier/nsIUrlListManager.idl:80
(Diff revision 2)
>       * for the update url. Update may still fail because of backoff algorithm.
>       */
>      boolean checkForUpdates(in ACString updateUrl);
> +
> +    /**
> +     * This is currently used by about:url-classifier to get back-off time

"...back-off time (in millisecond since epoch) for the given..."

Assuming I have the units right.

Comment 4

[Dimi Lee [:dimi]]

Comment on attachment 8877866 [details]
Bug 1373121 - about:url-classifier: Support get back-off time.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149288/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/522157b3680d
about:url-classifier: Support get back-off time. r=francois

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/522157b3680d