1373162 - Crash in java.lang.NullPointerException: at org.mozilla.gecko.media.GeckoHlsPlayer$ComponentListener.onVideoInputFormatChanged(GeckoHlsPlayer.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect)

Description

[Julien Cristau [:jcristau]]

This bug was filed from the Socorro interface and is 
report bp-cfeab3da-380b-4e74-9f25-65d9f0170614.
=============================================================

We got 4 reports with this signature on the 20170614 nightly build, and this looks like a new one.

Java stack trace:
java.lang.NullPointerException: Attempt to invoke virtual method 'void org.mozilla.gecko.media.GeckoHlsPlayer$HlsMediaTracksInfo.onVideoInfoUpdated()' on a null object reference
	at org.mozilla.gecko.media.GeckoHlsPlayer$ComponentListener.onVideoInputFormatChanged(GeckoHlsPlayer.java:257)
	at org.mozilla.gecko.media.GeckoHlsPlayer$ComponentEventDispatcher$2.run(GeckoHlsPlayer.java:214)
	at android.os.Handler.handleCallback(Handler.java:739)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at org.mozilla.gecko.GeckoThread.pumpMessageLoop(GeckoThread.java:431)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:405)

Comment 1

[Kilik Kuo [:kikuo] (inactive)]

Attachment: Bug 1373162 - Make sure GeckoHlsPlayer java callback runnable won't access a null object when player is removed.

Review commit: https://reviewboard.mozilla.org/r/149440/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149440/

Comment 2

[James Cheng[:JamesCheng]]

Comment on attachment 8878023 [details]
Bug 1373162 - Make sure GeckoHlsPlayer java callback runnable won't access a null object when player is removed.

https://reviewboard.mozilla.org/r/149440/#review154248

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHlsPlayer.java:50
(Diff revision 1)
>  @ReflectionTarget
>  public class GeckoHlsPlayer implements BaseHlsPlayer, ExoPlayer.EventListener {
>      private static final String LOGTAG = "GeckoHlsPlayer";
>      private static final DefaultBandwidthMeter BANDWIDTH_METER = new DefaultBandwidthMeter();
>      private static final int MAX_TIMELINE_ITEM_LINES = 3;
> -    private static boolean DEBUG = false;
> +    private static boolean DEBUG = AppConstants.DEBUG_BUILD;

Would you please modify this to "private static final boolean DEBUG = AppConstants.NIGHTLY_BUILD || AppConstants.DEBUG_BUILD;"?

I will create a follow up bug for the rest of java codes according to this change.

Comment 4

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8878023 [details]
Bug 1373162 - Make sure GeckoHlsPlayer java callback runnable won't access a null object when player is removed.

https://reviewboard.mozilla.org/r/149440/#review154248

> Would you please modify this to "private static final boolean DEBUG = AppConstants.NIGHTLY_BUILD || AppConstants.DEBUG_BUILD;"?
> 
> I will create a follow up bug for the rest of java codes according to this change.

Thanks for review

Comment 5

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8878023 [details]
Bug 1373162 - Make sure GeckoHlsPlayer java callback runnable won't access a null object when player is removed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149440/diff/1-2/

Comment 6

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8878023 [details]
Bug 1373162 - Make sure GeckoHlsPlayer java callback runnable won't access a null object when player is removed.

https://reviewboard.mozilla.org/r/149440/#review154280

Remove a log message in GeckoHlsPlayer.getSample because it's too annoying if we'd like to enable logging on nightly or debug build.

Comment 7

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8878023 [details]
Bug 1373162 - Make sure GeckoHlsPlayer java callback runnable won't access a null object when player is removed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149440/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21c7dab610ad
Make sure GeckoHlsPlayer java callback runnable won't access a null object when player is removed. r=JamesCheng

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/21c7dab610ad