1373202 - Harmonize behaviours between different pathways to recieving tabs

Status: RESOLVED FIXED

(Firefox for iOS :: Firefox Accounts, enhancement, P1)

Description

[James Hugman [:jhugman] [@jhugman]]

There are several implementations of SyncDelegate. This should all behave in the same way. 

When a tab is received by the app (either by Push or by periodic sync):
 * if the app is backgrounded, a notification should show up. 
 * if the app is foregrounded, the tab should open up.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This may be a P1. Not entirely sure yet.

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Work:

 * local notification has a category. remote notification does not.
 * local notification alert should not display if the application is active. It should just open the tab.

Comment 3

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2858

Comment 4

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8880625 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2858

LGTM. A couple of small comments on the PR.

Comment 5

[James Hugman [:jhugman] [@jhugman]]

Merged into master.

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Uplifted to v8.x