1373203 - Remove delivered push notifications if there are no tabs received

Status: RESOLVED FIXED

(Firefox for iOS :: Firefox Accounts, enhancement, P2)

Description

[James Hugman [:jhugman] [@jhugman]]

When a push notification is received with a sync:collections_changed event, and there are no tabs, only non-sensical message is possible. 

(current behaviour: Firefox Sync / Tap to begin).

In this case, we should try and recycle an existing notification, and then delete it so we make a best effort to make the current notification useful.

See also Bug 1373201.

In the case of other FxA push events, we should file other bugs.

https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/SupportingNotificationsinYourApp.html#//apple_ref/doc/uid/TP40008194-CH4-SW1

Comment 1

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2882

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Merged into master.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Uplifted to v8.x

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This patch has some odd side effects. I removed a device from my account, and as a result, notifications are being sent around. We don't know how to handle those, so I think this patch kicks in and shows the last tab notification again. It is better than "Tap to begin" but still not ideal.

(I understand the fxaccount:device_disconnected message will not be sent anymore, but I assume this can also happen for other notifications)

Comment 5

[Ryan Kelly [:rfkelly]]

> I understand the fxaccount:device_disconnected message will not be sent anymore

IIUC we had a rollback on the FxA server during the train-90 deployment, which would have also rolled back the code that disabled sending of these notifications to iOS devices.  I wonder if you saw some temporary weirdness due to the notifications briefly being sent again?

Comment 6

[Edouard Oger [:eoger]]

Keep in mind that Desktop also sends a sync:collections_changed event when syncing the clients collection for the first time.