Closed Bug 1373234 Opened 7 years ago Closed 6 years ago

Intermittent browser/components/extensions/test/browser/test-oop-extensions/browser_ext_menus.js | Test timed out | no tasks awaiting on messages - Got ["click"], expected [] | Extension left running at test shutdown | Found a tab

Categories

(WebExtensions :: Untriaged, defect, P5)

Product:
WebExtensions
Component:
Untriaged
Type:
defect

Tracking

(firefox-esr60 fixed, firefox62 fixed, firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox-esr60 --- fixed
firefox62 --- fixed
firefox63 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: robwu)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

Bug 1373234 - Avoid races in tests involving menu creation
59 bytes, text/x-review-board-request
mixedpuppy
: review+
Details
Bug 1373234 - Small cleanup in browser_ext_contextMenus*.js tests
59 bytes, text/x-review-board-request
mixedpuppy
: review+
Details
Priority: -- → P5
Product: Toolkit → WebExtensions
Blocks: 1321182
Assignee: nobody → rob
Status: NEW → ASSIGNED
Blocks: 1462862
Blocks: 1403429
Comment on attachment 8994799 [details]
Bug 1373234 - Avoid races in tests involving menu creation

https://reviewboard.mozilla.org/r/259346/#review266364

::: commit-message-0b9c0:3
(Diff revision 1)
> +browser.menus.create and browser.contextMenus.create are asynchronous
> +APIs. For compatibility reasons, they cannot return a promise (since
> +they already return an integer).

browser.menus.create should have been a promise, I guess it's too late.

::: browser/components/extensions/test/browser/browser_ext_contextMenus.js:23
(Diff revision 1)
>        browser.contextMenus.create({
>          id: "clickme-image",
>          title: "Click me!",
>          contexts: ["image"],
>        });
> +      browser.contextMenus.onClicked.addListener(() => {});

what is the point of this line?

::: browser/components/extensions/test/browser/browser_ext_contextMenus.js:29
(Diff revision 1)
>          id: "clickme-page",
>          title: "Click me!",
>          contexts: ["page"],
> -      });
> +      }, () => {
> -      browser.contextMenus.onClicked.addListener(() => {});
> -      browser.test.notifyPass();
> +        browser.test.notifyPass();

This is actually not a test pass.  Change all of these to sendmessage.

::: browser/components/extensions/test/browser/browser_ext_contextMenus_icons.js:38
(Diff revision 1)
>  
>        browser.contextMenus.create({
>          title: "child",
> -      });
> +      }, () => {
> -
> -      browser.test.notifyPass("contextmenus-icons");
> +        browser.test.notifyPass("contextmenus-icons");

not a pass

::: browser/components/extensions/test/browser/browser_ext_contextMenus_icons.js:127
(Diff revision 1)
>            id: "contextmenu-child3",
>            icons: {
>              18: "green_icon.png",
>            },
> +        }, () => {
> +          browser.test.notifyPass("extra-contextmenu-items-added");

not a pass
Attachment #8994799 - Flags: review?(mixedpuppy) → review+
Comment on attachment 8994905 [details]
Bug 1373234 - Small cleanup in browser_ext_contextMenus*.js tests

https://reviewboard.mozilla.org/r/259420/#review266444
Attachment #8994905 - Flags: review?(mixedpuppy) → review+
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/8cd5c902c0f8
Avoid races in tests involving menu creation r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/cae08ffe4804
Small cleanup in browser_ext_contextMenus*.js tests r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/8cd5c902c0f8
https://hg.mozilla.org/mozilla-central/rev/cae08ffe4804
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Flags: qe-verify-
The failure in comment 64 belongs to bug 1493090 .
See Also: → 1493090
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: