1373257 - Partner parameter for repack scripts should be the top level directory

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, enhancement, P1)

Description

[Mike Kaply [:mkaply]]

No idea if this is the right place for this, but it seems like it.

Currently the repack scripts take a partner parameter and they use that to match the subdirectories in the partner repacks.

The result of this is that to build the partner "mailru" you have to pass "mailru" and "okru"

The partner parameter should be the top level directory and when you pass it, it should simply build everything in that subdirectory. This will allow us to have differently named builds for a single partner.

Alternatively, we could pass a new parameter.

Comment 1

[Mike Kaply [:mkaply]]

So it looks like we have the parameter "--partners-dir" that allows you to specify the exact directory to use and then the cfg files are processed under that.

This gives us the function in theory, but I still think it's inconsistent with the behavior we want.

I think we should be able to pass the partner and just build the partner.

Comment 2

[Mike Kaply [:mkaply]]

https://github.com/mozilla-partners/repack-scripts/pull/22

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Pull request for patch

Comment 4

[Firefox Bug Husbandry Bot]

Bulk change of QA Contact to :jlund, per https://bugzilla.mozilla.org/show_bug.cgi?id=1428483