If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Crash in mozilla::ThreadStackHelper::FillStackBuffer

RESOLVED FIXED in Firefox 56

Status

()

Core
XPCOM
--
critical
RESOLVED FIXED
3 months ago
19 days ago

People

(Reporter: calixte, Assigned: mystor)

Tracking

(Blocks: 1 bug, {crash, regression})

55 Branch
mozilla56
x86
Windows 7
crash, regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox54 unaffected, firefox55 unaffected, firefox56 fixed)

Details

(Whiteboard: [clouseau], crash signature)

Attachments

(1 attachment)

(Reporter)

Description

3 months ago
This bug was filed from the Socorro interface and is 
report bp-ad27b2c3-1809-4c65-8fbe-5ad010170615.
=============================================================

There are 2 crashes in nightly 56 with buildid 20170615030208. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1357829.

[1] https://hg.mozilla.org/mozilla-central/rev?node=6123a6b2b7495adb14e753f3b3999a9beceb060f
Flags: needinfo?(michael)
(Assignee)

Comment 1

3 months ago
Created attachment 8878077 [details] [diff] [review]
Null-check mStackToFill before collecting psuedostacks

This was causing a crash on nightly. The browser would try to collect only a
native stack, and then attempt to dereference the null pointer for the
pseudostack. I think this didn't happen on infra as it only occurs when the user
has hung a sufficient number of times.

MozReview-Commit-ID: 6RSW2llKBjT
Attachment #8878077 - Flags: review?(nfroyd)
(Assignee)

Updated

3 months ago
Assignee: nobody → michael
Flags: needinfo?(michael)
Comment on attachment 8878077 [details] [diff] [review]
Null-check mStackToFill before collecting psuedostacks

Review of attachment 8878077 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8878077 - Flags: review?(nfroyd) → review+

Comment 3

3 months ago
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c83344a41561
Null-check mStackToFill before collecting psuedostacks, r=froydnj
https://hg.mozilla.org/mozilla-central/rev/c83344a41561
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox56: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
This is topcrash #4 for the Windows nightly of 20170615030208.
Presumably it will disappear when the fix makes it into the nightly channel.
Blocks: 1396527
You need to log in before you can comment on or make changes to this bug.