1373282 - mac dev edition builds and tests will be scheduled via bbb

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task, P2)

Description

[Kim Moir [:kmoir] ET]

Changes are required in buildbot to accommodate this.

See bug 1372588 for details

Comment 1

[Kim Moir [:kmoir] ET]

Sebastian, how is the work for the bug going?  This came up in the tcmigration meeting today.

Comment 2

[Sebastian Pacurar [:spacurar]]

I will attach the patches at the end of the day. Still working on it.

Comment 3

[Sebastian Pacurar [:spacurar]]

Attachment: bug_1373282_bb-mozilla.patch

I tried to add the osx devedition builder in the bnames list to be filtered along with the regular osx build, but diff showed no result. Also I don't think a patch for the tests are needed in mozilla-tests since tests need to be in their place because they will be scheduled by taskcluster but will run in buildbot. So I guess another patch would be about the tests to run just like the builds do. Am I right about this?

Comment 4

[Kim Moir [:kmoir] ET]

I think on a staging master you have to modify universal_master_sqlite.cfg to see the results. You can print the contents of pre and post or use pdb https://docs.python.org/2/library/pdb.html to debug

Comment 5

[Alin Selagea [:aselagea]]

Attachment: bug_1373282.patch

We stopped scheduling macosx64-devedition tests here [1], so we still need to do the same for the correspondent builders.

I took a look at the work done in bug 1353376 (see comment 51 and below [2] and the patch used [3]), then adapted that patch to also remove "OS X 10.7 mozilla-beta devedition build" from the list of scheduled builders.

Note: in the initial form, the patch was supposed to prevent us from scheduling all "OS X 10.7" opt builders from the trunk branches (then FX 55). Current buildbot devedition builder only runs on mozilla-beta (which has is now FX 55), so the 'for' loop should be okay.

[1] https://hg.mozilla.org/releases/mozilla-beta/rev/a93c354443ec
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1353376#c51
[3] https://bug1353376.bmoattachments.org/attachment.cgi?id=8864362

Comment 6

[Alin Selagea [:aselagea]]

Builder diff:

--- old 2017-07-04 08:20:59.643607006 -0700
+++ new 2017-07-04 08:50:40.323845148 -0700
@@ -4802,6 +4802,5 @@ Schedulers:
                <function buildUIDSchedFunc>],
  'treeStableTimer': None}
-<buildbotcustom.scheduler.Scheduler-props> {'builderNames': ['OS X 10.7 mozilla-beta devedition build',
-                  'WINNT 5.2 mozilla-beta devedition build',
+<buildbotcustom.scheduler.Scheduler-props> {'builderNames': ['WINNT 5.2 mozilla-beta devedition build',
                   'WINNT 6.1 x86-64 mozilla-beta devedition build'],
  'change_filter': <ChangeFilter on branch == releases/mozilla-beta>,

Comment 7

[Alin Selagea [:aselagea]]

Comment on attachment 8883339 [details] [diff] [review]
bug_1373282.patch

https://hg.mozilla.org/build/buildbot-configs/rev/256c3fc81980
https://hg.mozilla.org/build/buildbot-configs/rev/e2502913843c

Comment 8

[Alin Selagea [:aselagea]]

The buildbot builder is no longer scheduled after today's push.

e.g. 
https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=6f63c2d2089ace44d9c4b7cd8e7de9116c9835d3&filter-searchStr=devedition%20build%20os%20x