Update flake8 linter to version 3.3.0

RESOLVED FIXED in Firefox 56

Status

Testing
Lint
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

8 months ago
This is a major update from the previous version. The reason I'd like to upgrade is that it fixes some configuration bugs we were previously working around (see bug 1277851) and provides the ability to run in parallel, making it much faster.

It looks like it flags a new kind of error (E305) which enforces two whitespaces after the file. I'll fix those using autopep8.
(Assignee)

Updated

8 months ago
Blocks: 1367092
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 3

8 months ago
Here's the try run proving flake8 3.3.0 got installed.

Comment 4

8 months ago
mozreview-review
Comment on attachment 8878109 [details]
Bug 1373294 - Fix E305 (two blank lines after method or class) in files enabled by flake8 linter,

https://reviewboard.mozilla.org/r/149510/#review154088

yay whitespace
Attachment #8878109 - Flags: review?(jmaher) → review+

Comment 5

8 months ago
mozreview-review
Comment on attachment 8878110 [details]
Bug 1373294 - Update flake8 used to version 3.3.0,

https://reviewboard.mozilla.org/r/149512/#review154090

rubber stamp
Attachment #8878110 - Flags: review?(jmaher) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 8

8 months ago
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a51da7e10a0
Fix E305 (two blank lines after method or class) in files enabled by flake8 linter, r=jmaher
https://hg.mozilla.org/integration/autoland/rev/43d96b2dd775
Update flake8 used to version 3.3.0, r=jmaher
https://hg.mozilla.org/mozilla-central/rev/5a51da7e10a0
https://hg.mozilla.org/mozilla-central/rev/43d96b2dd775
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.