Closed Bug 1373294 Opened 3 years ago Closed 3 years ago

Update flake8 linter to version 3.3.0

Categories

(Firefox Build System :: Lint and Formatting, enhancement)

enhancement
Not set

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(2 files)

This is a major update from the previous version. The reason I'd like to upgrade is that it fixes some configuration bugs we were previously working around (see bug 1277851) and provides the ability to run in parallel, making it much faster.

It looks like it flags a new kind of error (E305) which enforces two whitespaces after the file. I'll fix those using autopep8.
Blocks: 1367092
Here's the try run proving flake8 3.3.0 got installed.
Comment on attachment 8878109 [details]
Bug 1373294 - Fix E305 (two blank lines after method or class) in files enabled by flake8 linter,

https://reviewboard.mozilla.org/r/149510/#review154088

yay whitespace
Attachment #8878109 - Flags: review?(jmaher) → review+
Comment on attachment 8878110 [details]
Bug 1373294 - Update flake8 used to version 3.3.0,

https://reviewboard.mozilla.org/r/149512/#review154090

rubber stamp
Attachment #8878110 - Flags: review?(jmaher) → review+
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a51da7e10a0
Fix E305 (two blank lines after method or class) in files enabled by flake8 linter, r=jmaher
https://hg.mozilla.org/integration/autoland/rev/43d96b2dd775
Update flake8 used to version 3.3.0, r=jmaher
https://hg.mozilla.org/mozilla-central/rev/5a51da7e10a0
https://hg.mozilla.org/mozilla-central/rev/43d96b2dd775
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Product: Testing → Firefox Build System
You need to log in before you can comment on or make changes to this bug.