1373308 - Error converting mail to task: guess is not defined

Status: RESOLVED FIXED

(Calendar :: Tasks, defect)

Description

[Sebastian Lemos Satue]

Attachment: thunderbird_lightning_task_error.PNG

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170518000419

Steps to reproduce:

Select a mail -> right click -> select "Convert to" -> select "Task"


Actual results:

Nothing on UI. In Error Console I found this errors:
ReferenceError: guess is not defined[Saber más]  calExtract.jsm:1284:13
	Extractor.prototype.guess resource://calendar/modules/calExtract.jsm:1284:13
	Extractor.prototype.extractDayMonthNameYear resource://calendar/modules/calExtract.jsm:408:33
	Extractor.prototype.extract resource://calendar/modules/calExtract.jsm:345:9
	calendarExtract.extractFromEmail chrome://calendar/content/calendar-extract.js:121:25
	oncommand chrome://messenger/content/messenger.xul:1:1


Expected results:

A new task should be created with the mail.

Comment 1

[Stefan Sitter [:ssitter]]

Thanks for reporting. Seems to be caused by this change: <https://hg.mozilla.org/comm-central/diff/fd02e757b142/calendar/base/modules/calExtract.jsm> in Bug 1280898. The variable guess was renamed to dateGuess but not all locations were updated.

Comment 2

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

Comment 3

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/0cac30b866ef093d76eadbe6d55f5d1c916f39d2

Comment 4

[Jorg K (CEST = GMT+2)]

Beta (TB 55, Calendar 5.7):
https://hg.mozilla.org/releases/comm-beta/rev/0019f0036204dda4cf920002a17829a55baa6aa0

Comment 5

[Jorg K (CEST = GMT+2)]

ESR (TB 52, Calendar 5.4)
https://hg.mozilla.org/releases/comm-esr52/rev/6ea4b3bc5ba14a8bc911b227779a05888ea63c13

Comment 6

[Martin Schröder [:mschroeder]]

5.4.2 has already been released, so this should be in 5.4.3 then.

Comment 7

[Martin Schröder [:mschroeder]]

Now I see, we need a new version 5.4.2.1 according to the tagging on comm-esr52. ;-)