1373317 - stylo: Bindgen upgrade busted mac builds due to prepended underscore

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement, P1)

Description

[Bobby Holley (:bholley)]

After a recent pull, mac won't link: https://gist.github.com/bholley/d0c35f1cad08efe0c8fa75c40ba6ac91

This is because bindings now include:

extern "C" {
    #[link_name = "_Gecko_MaybeCreateStyleChildrenIterator"]
    pub fn Gecko_MaybeCreateStyleChildrenIterator(node: RawGeckoNodeBorrowed)
     -> StyleChildrenIteratorOwnedOrNull;
}


Where there was previously no link_name specified.

I suspect https://github.com/servo/rust-bindgen/pull/729 , which landed in a bindgen update recently.

As a hacky workaround, you can do:

perl -ni.bak -e 'print unless /link_name/' PATH/TO/GENERATED/bindings.rs

But this obviously needs to be redone every time gecko headers change, which isn't great. We should fix this as soon as possible.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

https://github.com/servo/rust-bindgen/pull/752

and

https://github.com/servo/servo/pull/17341

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Both landed.