stylo: Bindgen upgrade busted mac builds due to prepended underscore

RESOLVED FIXED

Status

()

Core
Build Config
P1
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: bholley, Assigned: emilio)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 months ago
After a recent pull, mac won't link: https://gist.github.com/bholley/d0c35f1cad08efe0c8fa75c40ba6ac91

This is because bindings now include:

extern "C" {
    #[link_name = "_Gecko_MaybeCreateStyleChildrenIterator"]
    pub fn Gecko_MaybeCreateStyleChildrenIterator(node: RawGeckoNodeBorrowed)
     -> StyleChildrenIteratorOwnedOrNull;
}


Where there was previously no link_name specified.

I suspect https://github.com/servo/rust-bindgen/pull/729 , which landed in a bindgen update recently.

As a hacky workaround, you can do:

perl -ni.bak -e 'print unless /link_name/' PATH/TO/GENERATED/bindings.rs

But this obviously needs to be redone every time gecko headers change, which isn't great. We should fix this as soon as possible.
(Reporter)

Updated

7 months ago
Priority: -- → P1
(Reporter)

Updated

7 months ago
Flags: needinfo?(nfitzgerald)
Flags: needinfo?(emilio+bugs)
(Assignee)

Comment 1

7 months ago
https://github.com/servo/rust-bindgen/pull/752

and

https://github.com/servo/servo/pull/17341
Assignee: nobody → emilio+bugs
Flags: needinfo?(nfitzgerald)
Flags: needinfo?(emilio+bugs)
Blocks: 1356991
No longer blocks: 1243581
(Assignee)

Comment 2

7 months ago
Both landed.
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Blocks: 1375774
No longer blocks: 1356991
You need to log in before you can comment on or make changes to this bug.