Closed Bug 1373360 Opened 8 years ago Closed 3 years ago

Maximized Firefox doesn't allow for clicking on back button or menu button using the first or last pixel, respectively

Categories

(Core :: Widget: Win32, defect, P3)

Product:
Core
Component:
Widget: Win32
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: jaws, Unassigned)

Details

(Keywords: good-first-bug, polish, Whiteboard: tpi:+)

It looks like this broke with the recent Windows 10 update, 15063.413. I used mozregression and confirmed that this is not due to a recent change in Firefox. We have browser_backButtonFitts.js and browser_menuButtonFitts.js which are supposed to guard against this type of failure but I'm pretty sure that the testing machines aren't running this latest OS update. Expected: place the mouse cursor at the edge of the screen, adjacent to either the back button or menu button. These buttons should be clickable when the mouse is as far against the edge as possible.
This only happens with non-100% DPI.
Hey Jim, is this on your radar?
Flags: needinfo?(jmathies)
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2) > Hey Jim, is this on your radar? yep, but I kinda consider lower priority, maybe a P3 as things stand right now. Pretty polishy. actually, this would probably make a GFB too.
Flags: needinfo?(jmathies)
Keywords: good-first-bug, polish
Priority: -- → P3
Whiteboard: tpi:+
This doesn't happen in fullscreen mode (F11) .
This is where i stopped looking (would need to set a up dev env first before testing anything): https://dxr.mozilla.org/mozilla-central/source/widget/windows/nsWindow.cpp#2614 Then it came to my mind I have seen this behaviour (when rdp-ing to my system via mobile which then uses 200% DPI) way before that "recent Windows 10 update, 15063.413" and ran mozregression... Found it must have been a change between 2016-09-07 (good) and 2016-09-08 (bad). Sadly mozregression "Could not find enough data" and eventually stopped giving me this pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=91c2b9d5c1354ca79e5b174591dbb03b32b15bbf&tochange=938ce16be25f9c551c19ef8938e8717ed3d41ff5
Cloned the nightly and reverted https://hg.mozilla.org/mozilla-central/rev/c3771535a47e which fixes this issue for me (Windows 10). I think this bug should block https://bugzilla.mozilla.org/show_bug.cgi?id=1289143 .

I'm unable to reproduce this, but I'm on Windows 11. Jaws, would you happen to know if this is still an issue?

Flags: needinfo?(jaws)

This is indeed fixed. I'll close the bug. Thanks for the ping.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(jaws)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.