Clean some unused reftest annotations after enabling background color layer by default

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ethlin, Assigned: ethlin)

Tracking

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

I forgot to clean the these annotations in bug 1358055.
did you really mean to remove 3 tests altogether?
Comment on attachment 8878361 [details] [diff] [review]
Clean unused reftest annotations

Review of attachment 8878361 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with comment addressed

::: layout/reftests/bugs/reftest.list
@@ +1984,5 @@
>  fuzzy(2,20000) == 1315113-2.html 1315113-2-ref.html
>  == 1315632-1.html 1315632-1-ref.html
>  fuzzy(2,40000) fuzzy-if(webrender,26,691) == 1316719-1a.html 1316719-1-ref.html
>  fuzzy(2,40000) fuzzy-if(webrender,26,691) == 1316719-1b.html 1316719-1-ref.html
> +fuzzy(2,40000) fuzzy-if(webrender,26,691) == 1316719-1c.html 1316719-1-ref.html

This can be fuzzy-if(webrender,1-1,323-323). The actual fuzz numbers are reported in the log for the reftest on TreeHerder now, and this test (1316719-1c.html) has 1,323 as the fuzz factor. It's the same in all the R4 and Ru4 jobs (I checked e10s vs non-e10s and debug/opt as well) in a recent m-c push, so we can use a tight range for it.
Attachment #8878361 - Flags: review?(bugmail) → review+
(In reply to Robert Longson from comment #3)
> did you really mean to remove 3 tests altogether?

It's more like removing the runs which explicitly set a pref that is now set by default anyway.
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0e703b451c1
Clean some unused reftest annotations after enabling background color layer by default. r=kats
https://hg.mozilla.org/mozilla-central/rev/b0e703b451c1
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.