1373530 - Clean some unused reftest annotations after enabling background color layer by default

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ethan Lin[:ethlin]]

I forgot to clean the these annotations in bug 1358055.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Clean unused reftest annotations

Comment 2

[Ethan Lin[:ethlin]]

Comment on attachment 8878361 [details] [diff] [review]
Clean unused reftest annotations

try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c3d55f513444998de2f677296c6d7e29006a014&selectedJob=107574411

Comment 3

[Robert Longson [:longsonr]]

did you really mean to remove 3 tests altogether?

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8878361 [details] [diff] [review]
Clean unused reftest annotations

Review of attachment 8878361 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with comment addressed

::: layout/reftests/bugs/reftest.list
@@ +1984,5 @@
>  fuzzy(2,20000) == 1315113-2.html 1315113-2-ref.html
>  == 1315632-1.html 1315632-1-ref.html
>  fuzzy(2,40000) fuzzy-if(webrender,26,691) == 1316719-1a.html 1316719-1-ref.html
>  fuzzy(2,40000) fuzzy-if(webrender,26,691) == 1316719-1b.html 1316719-1-ref.html
> +fuzzy(2,40000) fuzzy-if(webrender,26,691) == 1316719-1c.html 1316719-1-ref.html

This can be fuzzy-if(webrender,1-1,323-323). The actual fuzz numbers are reported in the log for the reftest on TreeHerder now, and this test (1316719-1c.html) has 1,323 as the fuzz factor. It's the same in all the R4 and Ru4 jobs (I checked e10s vs non-e10s and debug/opt as well) in a recent m-c push, so we can use a tight range for it.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

(In reply to Robert Longson from comment #3)
> did you really mean to remove 3 tests altogether?

It's more like removing the runs which explicitly set a pref that is now set by default anyway.

Comment 6

[Ethan Lin[:ethlin]]

try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=38c865bee892086b252d9fe9a36055a6cf54937d

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0e703b451c1
Clean some unused reftest annotations after enabling background color layer by default. r=kats

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b0e703b451c1