Closed Bug 1373557 Opened 7 years ago Closed 7 years ago

application.registerForRemoteNotifications() called from background thread

Categories

(Firefox for iOS :: Browser, enhancement, P2)

Product:
Firefox for iOS
Component:
Browser
Platform:
Other
iOS
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Iteration:
1.24

People

(Reporter: farhan, Assigned: jhugman)

Details

(Whiteboard: [AutoPush])

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2836
55 bytes, text/x-github-pull-request
farhan
: review+
Details | Review 
The method application.registerForRemoteNotifications() is a UI API and cannot be called from a background thread. 

The method in FxALoginHelper

fileprivate func requestUserNotifications(_ application: UIApplication)

is being run from a background thread and calling the UI API from a background thread. 



ps: this bug brought to you by the new xcode9 UI main thread only feature
Assignee: nobody → jhugman
Status: NEW → ASSIGNED
Attachment #8878497 - Flags: review?(fpatel) → review+
Merged in to master.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [AutoPush] → [AutoPush][needsuplift]
Uplifted to v8.x
Whiteboard: [AutoPush][needsuplift] → [AutoPush]
Iteration: --- → 1.24
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: