application.registerForRemoteNotifications() called from background thread

RESOLVED FIXED

Status

()

P2
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: farhan, Assigned: jhugman)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [AutoPush])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
The method application.registerForRemoteNotifications() is a UI API and cannot be called from a background thread. 

The method in FxALoginHelper

fileprivate func requestUserNotifications(_ application: UIApplication)

is being run from a background thread and calling the UI API from a background thread. 



ps: this bug brought to you by the new xcode9 UI main thread only feature
(Assignee)

Updated

a year ago
Assignee: nobody → jhugman
Status: NEW → ASSIGNED
(Reporter)

Updated

a year ago
Attachment #8878497 - Flags: review?(fpatel) → review+
(Assignee)

Comment 2

a year ago
Merged in to master.
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Assignee)

Updated

a year ago
Whiteboard: [AutoPush] → [AutoPush][needsuplift]
Uplifted to v8.x
Whiteboard: [AutoPush][needsuplift] → [AutoPush]
Iteration: --- → 1.24
You need to log in before you can comment on or make changes to this bug.