Closed
Bug 1373603
Opened 7 years ago
Closed 7 years ago
Lots of WARNING: file /.../ipc/chromium/src/base/message_loop.cc, line 280
Categories
(Core :: IPC, enhancement)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: kanru, Assigned: kanru)
References
Details
Attachments
(1 file)
|
1.06 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
MessageLoop::AddDestructionObserver has DCHECK(this == current()) but we are using it in the constructor, before we set the TLS. We can simply initialize the mEventTarget after we set the TLS.
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → kchen
Attachment #8878428 -
Flags: review?(wmccloskey)
Attachment #8878428 -
Flags: review?(wmccloskey) → review+
|
||
Comment 2•7 years ago
|
||
Is this ready to land? All of this console spam is annoying. :) Thanks for fixing it!
Flags: needinfo?(kchen)
Pushed by kchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ec26c28b45a7 Initialize the mEventTarget after we setup MessageLoop::current() to silence a DCHECK. r=billm
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ec26c28b45a7
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•