Closed
Bug 1373651
Opened 7 years ago
Closed 7 years ago
Ensure we don't report too large GC-during-idle values
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(1 file)
|
1.87 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
I made a mistake in bug 1372042, and we may end up reporting > 100% values for GC. That is because duration is counted while doing GC slice, and idle duration in the caller. The patch ensures the current slice duration is calculated the same was as idle duration, and then possible sGCUnnotifiedTotalTime duration is added to it. That should give reasonable accurate numbers.
Attachment #8878494 -
Flags: review?(continuation)
|
||
Updated•7 years ago
|
Attachment #8878494 -
Flags: review?(continuation) → review+
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/80af4cec418f Ensure we don't report too large GC-during-idle values, r=mccr8
|
||
Comment 2•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/80af4cec418f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•6 years ago
|
Assignee: nobody → bugs
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•