icecc + ccache is broken

RESOLVED FIXED in Firefox 56

Status

()

Core
Build Config
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: aosmond, Assigned: aosmond)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
Regression from bug 1357825. If I back that bug out, it works again. It seems to be because MOZ_USING_SCCACHE is always set because of:

http://searchfox.org/mozilla-central/rev/20d16dadd336e0c6b97e3e19dc4ff907744b5734/build/moz.configure/toolchain.configure#130
(Assignee)

Updated

6 months ago
Blocks: 1357825
(Assignee)

Comment 1

6 months ago
Created attachment 8878509 [details] [diff] [review]
Only use sscache if enabled., v1
(Assignee)

Comment 2

6 months ago
Comment on attachment 8878509 [details] [diff] [review]
Only use sscache if enabled., v1

It isn't clear to me why it was always set to true, so this is just my naive fix which got things working again :).
Attachment #8878509 - Flags: review?(ted)
Comment on attachment 8878509 [details] [diff] [review]
Only use sscache if enabled., v1

Review of attachment 8878509 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about that! I can't believe this test has been broken the entire time it has existed.
Attachment #8878509 - Flags: review?(ted) → review+
(Assignee)

Updated

6 months ago
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
(Assignee)

Comment 4

6 months ago
try seems to pass: https://treeherder.mozilla.org/#/jobs?repo=try&revision=92ad3921b6e6394d727cb8f08aeb306b2012e22f

I also built locally (Linux) with icecc + ccache, and sccache only, and confirmed both variants built and used the respective ccache and sccache caches.

Comment 5

6 months ago
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6c34f6c5ed5
Only use sccache if enabled. r=ted

Comment 6

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f6c34f6c5ed5
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.