Closed
Bug 1373667
Opened 7 years ago
Closed 7 years ago
icecc + ccache is broken
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: aosmond, Assigned: aosmond)
References
Details
Attachments
(1 file)
|
1.13 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Regression from bug 1357825. If I back that bug out, it works again. It seems to be because MOZ_USING_SCCACHE is always set because of: http://searchfox.org/mozilla-central/rev/20d16dadd336e0c6b97e3e19dc4ff907744b5734/build/moz.configure/toolchain.configure#130
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
Comment on attachment 8878509 [details] [diff] [review] Only use sscache if enabled., v1 It isn't clear to me why it was always set to true, so this is just my naive fix which got things working again :).
Attachment #8878509 -
Flags: review?(ted)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8878509 [details] [diff] [review] Only use sscache if enabled., v1 Review of attachment 8878509 [details] [diff] [review]: ----------------------------------------------------------------- Sorry about that! I can't believe this test has been broken the entire time it has existed.
Attachment #8878509 -
Flags: review?(ted) → review+
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•7 years ago
|
||
try seems to pass: https://treeherder.mozilla.org/#/jobs?repo=try&revision=92ad3921b6e6394d727cb8f08aeb306b2012e22f I also built locally (Linux) with icecc + ccache, and sccache only, and confirmed both variants built and used the respective ccache and sccache caches.
Pushed by aosmond@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f6c34f6c5ed5 Only use sccache if enabled. r=ted
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f6c34f6c5ed5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•