Closed Bug 1373729 Opened 7 years ago Closed 7 years ago

Page Shot icon in browser chrome stays dark on themes with dark backgrounds

Categories

(Firefox :: Screenshots, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1379464

People

(Reporter: jdavidson, Unassigned)

Details

Attachments

(1 file)

Firefox Version: Nightly, 56.0a1

When I change the Firefox theme to something with a dark background, the icons in the browser Chrome turn white, except for the Page Shot icon.

Expected outcome: Page Shot icon turns white on themes with dark backgrounds
Actual outcome: Page shot icon stays dark on themes with dark backgrounds

See attached screenshot.
Component: Operations: Pageshot → Toolbars and Customization
Product: Cloud Services → Firefox
QA Contact: dthorn
Version: unspecified → 56 Branch
I assume this is dependent on the new manifest Bug 1329242 for icons.

Looks like it's a duplicate of: https://github.com/mozilla-services/screenshots/issues/2887

I know a few people have mentioned on compact dark it looks like the option is disabled.
Flags: needinfo?(jgruen)
Component: Toolbars and Customization → Screenshots
Product: Firefox → Cloud Services
Version: 56 Branch → unspecified
We're tracking this in the github link from comment 1 so I'll close this.

This recently became fixable with https://bugzilla.mozilla.org/show_bug.cgi?id=1329242

Thanks everyone
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Hey I think this was resolved invalid b/c we're tracking most screenshots bugs through github. However, the actual cause here is gecko-side so it should be tracked on Bugzilla as well. This should remain closed since the remaining work to get screenshots displaying correctly can be tracked here: 

https://bugzilla.mozilla.org/show_bug.cgi?id=1379464
Flags: needinfo?(jgruen)
Resolution: INVALID → DUPLICATE
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: