1373746 - Status in network monitor is ellipsized at some sizes

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Espen H]

Attachment: status_ellipsized.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36 OPR/38.0.2220.41

Steps to reproduce:

When using network monitor at some sizes, notably right above the 700 px breakpoint, the status column is ellipsized when enough columns are present..


Actual results:

The status code was ellipsized, and therefore not legible due to there not being enough space


Expected results:

The status should be visible on all sizes, and never ellipsized

Comment 1

[Espen H]

Attachment: Bug 1373746 - Fix netmon status being ellipsized on some sizes.

Review commit: https://reviewboard.mozilla.org/r/149906/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149906/

Comment 2

[Patrick Brosset <:pbro>]

Honza, could you please take a look at that?

Comment 3

[Oriol Brufau [:Oriol]]

Please don't hardcode big minimum widths, use something like

.requests-list-status {
    text-overflow: initial;
}

Comment 4

[Espen H]

Comment on attachment 8878586 [details]
Bug 1373746 - Fix netmon status being ellipsized on some sizes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149906/diff/1-2/

Comment 5

[Espen H]

Fair enough. That seemed to work as well. I updated the review request, looks better?

Comment 6

[Oriol Brufau [:Oriol]]

Yes, thanks.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8878586 [details]
Bug 1373746 - Fix netmon status being ellipsized on some sizes.

https://reviewboard.mozilla.org/r/149906/#review157750

@Espen: please append a reviewer to the commit message.

Honza

::: devtools/client/netmonitor/src/assets/styles/netmonitor.css:339
(Diff revision 2)
>  /* Status column */
>  
>  .requests-list-status {
>    width: 8%;
> +   /* Don't ellipsize status codes */
> +  text-overflow: initial;

This fixes the proble for me, thanks!

Comment 8

[Espen H]

Comment on attachment 8878586 [details]
Bug 1373746 - Fix netmon status being ellipsized on some sizes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149906/diff/2-3/

Comment 9

[Espen H]

> @Espen: please append a reviewer to the commit message.

Done

Comment 10

[Oriol Brufau [:Oriol]]

Comment on attachment 8878586 [details]
Bug 1373746 - Fix netmon status being ellipsized on some sizes.

https://reviewboard.mozilla.org/r/149906/#review157756

Not sure if I'm allowed to review, but LGTM.

Comment 11

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Oriol [:Oriol] from comment #10)
> Not sure if I'm allowed to review, but LGTM.
R+ from me too so this can land.

Thanks all!

Honza

Comment 12

[Oriol Brufau [:Oriol]]

(In reply to Jan Honza Odvarko [:Honza] from comment #11)
> R+ from me too so this can land.

Let's land this, then.

Comment 13

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8878586 [details]
Bug 1373746 - Fix netmon status being ellipsized on some sizes.

https://reviewboard.mozilla.org/r/149906/#review163632

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b3e8c8aaeca
Fix netmon status being ellipsized on some sizes. r=Honza,Oriol

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7b3e8c8aaeca