Closed
Bug 1373746
Opened 7 years ago
Closed 7 years ago
Status in network monitor is ellipsized at some sizes
Categories
(DevTools :: Netmonitor, defect, P3)
DevTools
Netmonitor
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: dev+mozbugzilla, Assigned: dev+mozbugzilla)
Details
Attachments
(2 files)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36 OPR/38.0.2220.41 Steps to reproduce: When using network monitor at some sizes, notably right above the 700 px breakpoint, the status column is ellipsized when enough columns are present.. Actual results: The status code was ellipsized, and therefore not legible due to there not being enough space Expected results: The status should be visible on all sizes, and never ellipsized
Updated•7 years ago
|
Component: Untriaged → Developer Tools: Netmonitor
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
Please don't hardcode big minimum widths, use something like .requests-list-status { text-overflow: initial; }
Comment hidden (mozreview-request) |
Fair enough. That seemed to work as well. I updated the review request, looks better?
Flags: needinfo?(oriol-bugzilla)
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8878586 [details] Bug 1373746 - Fix netmon status being ellipsized on some sizes. https://reviewboard.mozilla.org/r/149906/#review157750 @Espen: please append a reviewer to the commit message. Honza ::: devtools/client/netmonitor/src/assets/styles/netmonitor.css:339 (Diff revision 2) > /* Status column */ > > .requests-list-status { > width: 8%; > + /* Don't ellipsize status codes */ > + text-overflow: initial; This fixes the proble for me, thanks!
Updated•7 years ago
|
Assignee: nobody → dev+mozbugzilla
Flags: needinfo?(odvarko)
Priority: -- → P3
Comment hidden (mozreview-request) |
> @Espen: please append a reviewer to the commit message.
Done
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8878586 [details] Bug 1373746 - Fix netmon status being ellipsized on some sizes. https://reviewboard.mozilla.org/r/149906/#review157756 Not sure if I'm allowed to review, but LGTM.
Attachment #8878586 -
Flags: review?(oriol-bugzilla) → review+
Comment 11•7 years ago
|
||
(In reply to Oriol [:Oriol] from comment #10) > Not sure if I'm allowed to review, but LGTM. R+ from me too so this can land. Thanks all! Honza
Comment 12•7 years ago
|
||
(In reply to Jan Honza Odvarko [:Honza] from comment #11) > R+ from me too so this can land. Let's land this, then.
Keywords: checkin-needed
Comment 13•7 years ago
|
||
mozreview-review |
Comment on attachment 8878586 [details] Bug 1373746 - Fix netmon status being ellipsized on some sizes. https://reviewboard.mozilla.org/r/149906/#review163632
Attachment #8878586 -
Flags: review+
Comment 14•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7b3e8c8aaeca Fix netmon status being ellipsized on some sizes. r=Honza,Oriol
Keywords: checkin-needed
Comment 15•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7b3e8c8aaeca
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•