Status in network monitor is ellipsized at some sizes

RESOLVED FIXED in Firefox 56

Status

defect
P3
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: dev+mozbugzilla, Assigned: dev+mozbugzilla)

Tracking

Trunk
Firefox 56

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

2 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36 OPR/38.0.2220.41

Steps to reproduce:

When using network monitor at some sizes, notably right above the 700 px breakpoint, the status column is ellipsized when enough columns are present..


Actual results:

The status code was ellipsized, and therefore not legible due to there not being enough space


Expected results:

The status should be visible on all sizes, and never ellipsized
Component: Untriaged → Developer Tools: Netmonitor
Comment hidden (mozreview-request)
Honza, could you please take a look at that?
Flags: needinfo?(odvarko)
Please don't hardcode big minimum widths, use something like

.requests-list-status {
    text-overflow: initial;
}
Comment hidden (mozreview-request)
Assignee

Comment 5

2 years ago
Fair enough. That seemed to work as well. I updated the review request, looks better?
Flags: needinfo?(oriol-bugzilla)
Yes, thanks.
Flags: needinfo?(oriol-bugzilla)
Comment on attachment 8878586 [details]
Bug 1373746 - Fix netmon status being ellipsized on some sizes.

https://reviewboard.mozilla.org/r/149906/#review157750

@Espen: please append a reviewer to the commit message.

Honza

::: devtools/client/netmonitor/src/assets/styles/netmonitor.css:339
(Diff revision 2)
>  /* Status column */
>  
>  .requests-list-status {
>    width: 8%;
> +   /* Don't ellipsize status codes */
> +  text-overflow: initial;

This fixes the proble for me, thanks!
Assignee: nobody → dev+mozbugzilla
Flags: needinfo?(odvarko)
Priority: -- → P3
Comment hidden (mozreview-request)
Assignee

Comment 9

2 years ago
> @Espen: please append a reviewer to the commit message.

Done

Comment 10

2 years ago
mozreview-review
Comment on attachment 8878586 [details]
Bug 1373746 - Fix netmon status being ellipsized on some sizes.

https://reviewboard.mozilla.org/r/149906/#review157756

Not sure if I'm allowed to review, but LGTM.
Attachment #8878586 - Flags: review?(oriol-bugzilla) → review+
(In reply to Oriol [:Oriol] from comment #10)
> Not sure if I'm allowed to review, but LGTM.
R+ from me too so this can land.

Thanks all!

Honza
(In reply to Jan Honza Odvarko [:Honza] from comment #11)
> R+ from me too so this can land.

Let's land this, then.
Keywords: checkin-needed
Comment on attachment 8878586 [details]
Bug 1373746 - Fix netmon status being ellipsized on some sizes.

https://reviewboard.mozilla.org/r/149906/#review163632
Attachment #8878586 - Flags: review+

Comment 14

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7b3e8c8aaeca
Fix netmon status being ellipsized on some sizes. r=Honza,Oriol
Keywords: checkin-needed

Comment 15

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7b3e8c8aaeca
Status: UNCONFIRMED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

Updated

a year ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.