This causes Windows ASan builds to crash soon after startup. https://dxr.mozilla.org/mozilla-central/rev/fe809f57bf2287bb937c3422ed03a63740b3448b/intl/icu/source/common/locmap.c#1053 Line 1053 sets pPosixID = locName. Then locName goes out of scope, but the function continues to use pPosixID. With Waldo away, I'm not sure who to talk to about ICU stuff. André, perhaps you might be able to help get this fixed?
(In reply to David Major [:dmajor] from comment #0) > With Waldo away, I'm not sure who to talk to about ICU stuff. André, perhaps > you might be able to help get this fixed? I can try to fix this issue after bug 1353650 (to avoid creating two different ICU patches). The general procedure when we need to patch our local ICU copy is as follows: - We create a bug report upstream (http://bugs.icu-project.org/trac/newticket), so the ICU team gets informed about a potential problem. - We create the patch and add it to the intl/icu-patches folder (http://searchfox.org/mozilla-central/source/intl/icu-patches). - Then we apply the patch to our ICU copy. - And if necessary, we recompile the precompiled ICU data file (but this step is only needed when ICU's data processing was modified, so it's not relevant to this issue).
Created attachment 8882219 [details] [diff] [review] bug1373763.patch This change should fix the ASan issue, right?
Comment on attachment 8882219 [details] [diff] [review] bug1373763.patch Thanks!
Clearing checkin-needed to amend the patch to match upstream.
Created attachment 8884532 [details] [diff] [review] bug1373763.patch Updated patch to match upstream, carrying r+ from dmajor. Only difference compared to the previous patch: The local variable is now explicitly initialized.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3a8ffdd05415 Extend scope for local variable in uprv_convertToPosix. r=dmajor