Closed
Bug 1373768
Opened 7 years ago
Closed 7 years ago
Use Services.wm instead of getService(Ci.nsIWindowMediator)
Categories
(DevTools :: JSON Viewer, defect)
DevTools
JSON Viewer
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: Oriol, Assigned: Oriol)
Details
Attachments
(1 file)
|
2.12 KB,
patch
|
Honza
:
review+
|
Details | Diff | Splinter Review |
In bug 1327784 I didn't notice Services.wm can be used instead of Cc["@mozilla.org/appshell/window-mediator;1"].getService(Ci.nsIWindowMediator) This way is cleaner.
Attachment #8878611 -
Flags: review?(odvarko)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8878611 [details] [diff] [review] json-wm.patch Review of attachment 8878611 [details] [diff] [review]: ----------------------------------------------------------------- LGTM! R+ Honza
Attachment #8878611 -
Flags: review?(odvarko) → review+
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/43d79f61e982 Use Services.wm instead of getService(Ci.nsIWindowMediator). r=Honza
Keywords: checkin-needed
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/43d79f61e982
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•