1373772 - Switch marionette unit test over to a webextension

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement)

Description

[Andrew Swan [:aswan]]

The unit test in testing/marionette/harness/marionette_harness/tests/unit/test_addons.py installs an extension, but it uses a legacy extension which will stop working in Firefox 57.  Lets switch it to a webextension.

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1373772 Use webextensions in marionette unit tests

This test currently uses a legacy extension that won't work in 57,
switch it to a webextension.

Review commit: https://reviewboard.mozilla.org/r/149932/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149932/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8878618 [details]
Bug 1373772 Use webextensions in marionette unit tests

https://reviewboard.mozilla.org/r/149932/#review155190

I downloaded the patch to check the content of the webextension, but the patch file doesn't contain anything? Also please replace the addon under `marionette_harness/www/`.

Comment 3

[Andrew Swan [:aswan]]

(In reply to Henrik Skupin (:whimboo) from comment #2)
> I downloaded the patch to check the content of the webextension, but the
> patch file doesn't contain anything?

How did you download the patch?  If nothing else, you should be able to see the diffs in reviewboard?

> Also please replace the addon under
> `marionette_harness/www/`.

This bug is just meant to do what's neceessary to get our automation running in builds where legacy extensions are disabled and no test that uses that code is currently breaking.  It looks like maybe test_clicks.py isn't testing what it is meant to test, but if you want to open a separate bug for that, I'd be happy to help you with it.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Andrew Swan [:aswan] from comment #3)
> How did you download the patch?  If nothing else, you should be able to see
> the diffs in reviewboard?

I downloaded it via MozReview's "Download Diff" feature given that MozReview cannot display binary content.

> This bug is just meant to do what's neceessary to get our automation running
> in builds where legacy extensions are disabled and no test that uses that
> code is currently breaking.  It looks like maybe test_clicks.py isn't
> testing what it is meant to test, but if you want to open a separate bug for
> that, I'd be happy to help you with it.

This specific test doesn't install the extension, but waits for the notification popup to appear. So it should only be necessary to replace the extension. Nothing should break. With that we won't have any other legacy extension laying around for Marionette anymore.

Comment 5

[Andrew Swan [:aswan]]

Comment on attachment 8878618 [details]
Bug 1373772 Use webextensions in marionette unit tests

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149932/diff/1-2/

Comment 6

[Andrew Swan [:aswan]]

Updated to also replace the xpi from comment 2.

As for looking at the new xpi files, the two are identical, they contain just a manifest.json with the contents:

{
  "manifest_version": 2,
  "name": "install test",
  "description": "install test",
  "version": "1.0"
}

If you want to verify that yourself you could pull or import the new revision into your local repo and then just look at the xpi file locally?  I'm not sure what else to do since these tests are written to require binary files checked into the tree...

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8878618 [details]
Bug 1373772 Use webextensions in marionette unit tests

https://reviewboard.mozilla.org/r/149932/#review156872

I was a bit anxious first when I saw the removal of the legacy extensions in this patch, but after talking to Andrew on IRC I realized that the part we test here in Marionette is just that we can install an XPI file. More detailed tests for both legacy or web extensions should be done for the add-on manager mochitests. Only having web extensions now, should be fine because other harnesses which use Marionette to install extensions might still install legacy ones, so if we regress something we will see it anyway.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cb48d9fe531
Use webextensions in marionette unit tests r=whimboo

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0cb48d9fe531