13738 - MLK: nsDTDContext::SaveToken()

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P1)

Description

[Bruce Mitchener]

Solaris 2.6, gcc 2.7.2.3.  Build from September 13, 1999.  Opened viewer, loaded
initial page, went to www.visa.com, selected the 'back to school' specials link,
quit.

MLK: 52 bytes leaked at 0x45d020
  * This memory was allocated from:
        malloc         [rtlib.o]
        __bUiLtIn_nEw  [libraptorgfx.so]
        __builtin_new  [rtlib.o]
        nsDTDContext::SaveToken(CToken*,int) [nsDTDUtils.cpp:358]
        CNavDTD::HandleOmittedTag(CToken*,nsHTMLTag,nsHTMLTag,nsIParserNode&)
[CNavDTD.cpp:1186]
        CNavDTD::HandleDefaultStartToken(CToken*,nsHTMLTag,nsIParserNode&)
[CNavDTD.cpp:989]
        CNavDTD::HandleStartToken(CToken*) [CNavDTD.cpp:1299]
        NavDispatchTokenHandler(CToken*,nsIDTD*) [CNavDTD.cpp:241]
        CTokenHandler::operator ()(CToken*,nsIDTD*) [nsTokenHandler.cpp:80]
        CNavDTD::HandleToken(CToken*,nsIParser*) [CNavDTD.cpp:740]

CNavDTD::BuildModel(nsIParser*,nsITokenizer*,nsITokenObserver*,nsIContentSink*)
[CNavDTD.cpp:551]
        nsParser::BuildModel() [nsParser.cpp:942]
        nsParser::ResumeParse(nsIDTD*,int) [nsParser.cpp:887]

nsParser::OnDataAvailable(nsIChannel*,nsISupports*,nsIInputStream*,unsigned
int,unsigned int) [nsParser.cpp:1288]

nsDocumentBindInfo::OnDataAvailable(nsIChannel*,nsISupports*,nsIInputStream*,unsigned
int,unsigned int) [nsDocLoader.cpp:2000]

nsChannelListener::OnDataAvailable(nsIChannel*,nsISupports*,nsIInputStream*,unsigned
int,unsigned int) [nsDocLoader.cpp:2272]

nsHTTPResponseListener::OnDataAvailable(nsIChannel*,nsISupports*,nsIInputStream*,unsigned
int,unsigned int) [nsHTTPResponseListener.cpp:186]
        nsOnDataAvailableEvent::HandleEvent() [nsAsyncStreamListener.cpp:344]
        nsStreamListenerEvent::HandlePLEvent(PLEvent*)
[nsAsyncStreamListener.cpp:144]
        PL_HandleEvent [plevent.c:509]
        PL_ProcessPendingEvents [plevent.c:470]
        nsEventQueueImpl::ProcessPendingEvents() [nsEventQueue.cpp:118]
        event_processor_callback(void*,int,GdkInputCondition)
[nsAppShell.cpp:153]
        gdk_io_invoke  [gdkevents.c:868]
        g_io_unix_dispatch [giounix.c:131]
        g_main_dispatch [gmain.c:647]
        g_main_iterate [gmain.c:854]
        g_main_run     [gmain.c:912]
        gtk_main       [gtkmain.c:475]
        nsAppShell::Run() [nsAppShell.cpp:379]

Comment 1

[Jan Carpenter]

Build [1999091409]

bruce, I am unable to reproduce this crash on WinNT, Win98, Mac, or Linux.  You
have the Platform and OS of this bug set to "All."   Are you seeing this bug on
all platforms?

Comment 2

[Bruce Mitchener]

That's because this isn't a crash. :)  It's a memory leak which merely means
that the memory being allocated at line 358 in nsDTD::SaveToken() is not being
freed (released).  If you'd like further explanations or to learn how to
reproduce these or verify the resolution, feel free to email me.

Comment 3

[rickg]

Harish -- this one is for you.

Comment 4

[harishd]

This bug uncovered a couple of problems. Firstly, illegal-tokens were not
getting recycled and secondly, the the deque that stored the illegal-tokens was
not getting freed.  checked in a fix.

Comment 5

[Jan Carpenter]

reporter has not responded.  I can't reproduce, marking verified.