[mozmill] testWeeklyWithExceptionRecurrence.js failing on all platforms, Linux more than others

RESOLVED FIXED in 5.8

Status

Calendar
Internal Components
P2
normal
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: Jorg K (GMT+1), Assigned: Taraman)

Tracking

({intermittent-failure})

Trunk
x86
Linux
intermittent-failure

Details

(Whiteboard: [Thunderbird-testfailure: Z all])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 months ago
+++ This bug was initially created as a clone of Bug #1329957 +++
(Assignee)

Comment 1

6 months ago
running locally I saw, that in week view, where the failures occur the event boxes appear sequentially.
So most probably this is a timing issue again.

I'll prepare a patch that changes the logic to wait for the last event and then checks for the preceding ones.
(Assignee)

Comment 2

6 months ago
I have a patch ready, unfortunately tryserver does not seem to run the mozmill-tests on linux debug builds...
(Reporter)

Comment 3

6 months ago
Tom, can you please take a look:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=6f8003d16c46b22a8fbfe2bddef31653c6d6468c

No Mozmill run for Linux 32/64 debug. Maybe related to bug 1342828?
Flags: needinfo?(mozilla)
It looks like the try parser doesn't know about the chunked mozmill tests. (https://bugzilla.mozilla.org/attachment.cgi?id=8880478&action=diff)
Flags: needinfo?(mozilla)
(Reporter)

Comment 5

6 months ago
This test also fails on Windows debug:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=b244943f2b123b5ca13cdf913835a131cf6bd99c&selectedJob=109536084
Keywords: intermittent-failure
Whiteboard: [Thunderbird-testfailure: Z Linux, Mac] → [Thunderbird-testfailure: Z all]
(Reporter)

Updated

6 months ago
Summary: [mozmill] testWeeklyWithExceptionRecurrence.js failing on Linux and Mac → [mozmill] testWeeklyWithExceptionRecurrence.js failing on all platforms, Linux more than others
(Reporter)

Comment 6

6 months ago
Can you do your testing on Windows debug since it fails there, too?
You can also change try request to be `-u mozmill,mozmill-1,mozmill-2` to get the mozmill tests to run on both linux and elsewhere. (Untested)
(Assignee)

Comment 8

6 months ago
In these try-runs, the respective test is not failing:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9ff7bd753c8dc4dd33a45da767c28aeb1e2fedf2
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7d52df35197f288e51bb2aa60d2ad3e37333078d
(Assignee)

Comment 9

6 months ago
Created attachment 8881946 [details] [diff] [review]
Fix V1.0

This patch fixes the test as shown in the try-builds in the previous comment.
Assignee: nobody → Mozilla
Status: NEW → ASSIGNED
Attachment #8881946 - Flags: review?(jorgk)
(Reporter)

Comment 10

6 months ago
Comment on attachment 8881946 [details] [diff] [review]
Fix V1.0

Review of attachment 8881946 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I have no review rights in calendar/. If Philipp is too busy, perhaps redirect to someone else with review rights.

::: calendar/test/mozmill/cal-recurrence/testWeeklyWithExceptionRecurrence.js
@@ +177,2 @@
>      controller.assertNode(lookupEventBox("week", EVENT_BOX, null, 4, HOUR));
> +    controller.assertNodeNotExist(lookupEventBox("week", EVENT_BOX, null, 5, HOUR));    

Nit: Trailing space.
Attachment #8881946 - Flags: review?(jorgk) → review?(philipp)
(Assignee)

Comment 11

6 months ago
Hrmpf. I linted it to prevent this. Obviously eslint is not working properly in my installation...
(Assignee)

Comment 12

5 months ago
Comment on attachment 8881946 [details] [diff] [review]
Fix V1.0

Shifting Review to makeyday, since Philipp seems to be busy right now.
Attachment #8881946 - Flags: review?(philipp) → review?(makemyday)

Comment 13

5 months ago
Comment on attachment 8881946 [details] [diff] [review]
Fix V1.0

Review of attachment 8881946 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, r+ with the whitespaces removed.
Attachment #8881946 - Flags: review?(makemyday) → review+
(Assignee)

Comment 14

5 months ago
Created attachment 8886876 [details] [diff] [review]
Fix V1.1

Patch with the fixed whitespace
Attachment #8886876 - Flags: review+
(Assignee)

Comment 15

5 months ago
Pushed to c-c:
https://hg.mozilla.org/comm-central/rev/0170000376576d23e86bd8faa3e51c4e659f85c2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 5.5
(Assignee)

Updated

5 months ago
Attachment #8881946 - Attachment is obsolete: true
Attachment #8886876 - Attachment is patch: true
Target Milestone: 5.5 → 5.8
(Reporter)

Comment 16

5 months ago
Not a total success since the test failure is still there on Linux 32bit.
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=0170000376576d23e86bd8faa3e51c4e659f85c2&selectedJob=114715679

It seems to be gone from Linux 64bit.
(Assignee)

Comment 17

5 months ago
The failure there hoever is an unhappy coincidence with another problem.

[1] shows
> EXCEPTION: Timeout waiting for modal dialog to open.
Which leads to a different issue. Sometimes the Event-Dialog fails to open in Time (>30s) on the debug-builds. Since this happens very rarely, I did not think about changing this timeout up to now.


[1]: https://treeherder.mozilla.org/logviewer.html#?job_id=114715679&repo=comm-central&lineNumber=14482
You need to log in before you can comment on or make changes to this bug.