Closed
Bug 1373810
Opened 7 years ago
Closed 7 years ago
Prefixes are confusing
Categories
(Socorro :: Symbols, task)
Socorro
Symbols
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: peterbe, Assigned: peterbe)
Details
All existing symbols (in AWS webeng) are uploaded into a prefix directory called "v1". And this is copied into Tecken with this https://github.com/mozilla-services/tecken/blob/de646a1b1e16e311bee1e404accb0e3a4288709c/tecken/settings.py#L398 That way, uploaders (of .zip) files don't need to specify the prefix. It gets set by Tecken automatically. However, for Symbol Download and Symbolication you're expected to set this in the DJANGO_SYMBOL_URLS. E.g. `https://s3.amazonaws.com/symbols-public-dev/v1` but that's easy to miss. Best to keep it safe and simple but still with the possibility to override with environment variables. So, If you do set `DJANGO_SYMBOL_URLS=https://s3.amazonaws.com/symbols-public-dev` it will use `settings.UPLOAD_FILE_PREFIX` as the prefix automagically. Note; If you set `DJANGO_SYMBOL_URLS=https://s3.amazonaws.com/symbols-public-dev/iknowmyprefixes` then that settings.UPLOAD_FILE_PREFIX will not be used. Note 2; The name "UPLOAD_FILE_PREFIX" isn't a good name since it's going to be used for both uploads and downloads.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → peterbe
Assignee | ||
Comment 1•7 years ago
|
||
PR https://github.com/mozilla-services/tecken/pull/179
Comment 2•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla-services/tecken https://github.com/mozilla-services/tecken/commit/3a11737fcbc3020f2783efff6ca037834cd7bdfe fixes bug 1373810 - Prefixes are confusing (#179)
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•