Closed Bug 1373828 Opened 5 years ago Closed 5 years ago

stylo: workaround servo/rust-bindgen#734

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

With the bindgen update, nsPresContext in debug mode is wrongly sized, because of  https://github.com/servo/rust-bindgen/issues/734.

Before https://github.com/servo/rust-bindgen/pull/736, the result wasn't particularly better, because the bitfield accessors in nsPresContext were wrong (which is IMO more problematic).

I don't know what the best way to fix https://github.com/servo/rust-bindgen/issues/734 is yet (because all of the ways to do so I can think of are really ugly), but the workaround Gecko-side is easy enough.
Comment on attachment 8878700 [details]
Bug 1373828: Work around servo/rust-bindgen#734.

https://reviewboard.mozilla.org/r/150014/#review154698

r=me with a bug filed to run the struct layout tests as part of mach check.
Attachment #8878700 - Flags: review?(bobbyholley) → review+
https://hg.mozilla.org/mozilla-central/rev/956c34d23e87
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee: nobody → emilio
You need to log in before you can comment on or make changes to this bug.