1373834 - Opt-out prompt for search suggestions brings to wrong preferences pane

Status: RESOLVED DUPLICATE of bug 1372528

(Firefox :: Address Bar, defect)

Description

[Mike Hommey [:glandium]]

STR:
- Download 55.0b2
- Open it on a new profile
- Type something in the location bar
- You get search suggestions (I'd argue this should be opt-in, rather than opt-out, but anyways), and a tooltip saying "Tip: Get help finding things, etc." with a Change preferences link.
- Click the Change preferences link.

Actual result:
- This opens a tab on about:preferences#general-search, which is just the "General" tab

Expected result:
- A tab open on about:preferences#search.

On nightly, this works because about:preferences#general-search does bring to the general pane, specialized for search, but that doesn't exist on beta.

Comment 1

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #0)
> - You get search suggestions (I'd argue this should be opt-in, rather than
> opt-out, but anyways)

Actually, this *was* opt-in up to and including 54, where the tooltip asked whether to enable suggestions, with a yes/no couple of buttons, which is a much better experience IMHO (especially for an opt-out)

Comment 2

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #0)
> Actual result:
> - This opens a tab on about:preferences#general-search, which is just the
> "General" tab

This is also true when clicking the settings icon next to the search engine icons, for obvious reasons.