Allow passing a built display list to PushBuiltDisplayList by reference instead of value

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Previously we needed to pass by value and that was causing us to clear out our prebuilt display list when we actually wanted to keep it around.

The rust code ended up doing a bit of a silly dance but that's better than copying the display list around.
(Assignee)

Comment 1

a year ago
Created attachment 8878716 [details] [diff] [review]
Pass by reference
Assignee: nobody → jmuizelaar
Attachment #8878716 - Flags: review?(a.beingessner)
(Assignee)

Updated

a year ago
Depends on: 1373863
(Assignee)

Updated

a year ago
Blocks: 1373863
No longer depends on: 1373863
(Assignee)

Updated

a year ago
Depends on: 1373381
Comment on attachment 8878716 [details] [diff] [review]
Pass by reference

Review of attachment 8878716 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. The replace is a bit wonky but it makes sense.
Attachment #8878716 - Flags: review+

Comment 3

a year ago
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b5d67cb0889
Pass a built display list to PushBuiltDisplayList by reference instead of value. r=Ganrko

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8b5d67cb0889
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Attachment #8878716 - Flags: review?(a.beingessner) → review+
You need to log in before you can comment on or make changes to this bug.