Closed Bug 1373866 Opened 7 years ago Closed 7 years ago

pr_wp.opHead accessed unlocked in uxproces.c

Categories

(NSPR :: NSPR, enhancement)

Product:
NSPR
Component:
NSPR
Platform:
x86_64
Linux
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: keeler, Assigned: keeler)

Details

Attachments

(1 file)

1373866-pr_wp.opHead.diff
1.40 KB, patch
KaiE
: review+
Details | Diff | Splinter Review 
The global struct pr_wp has a lock that protects its members against multithreaded access. opHead is protected by this lock everywhere except https://dxr.mozilla.org/mozilla-central/rev/fe809f57bf2287bb937c3422ed03a63740b3448b/nsprpub/pr/src/md/unix/uxproces.c#628
Assignee: nobody → dkeeler

        Attachment #8879747 -
        Flags: review?(kaie)

    
    

    
  
Comment on attachment 8879747 [details] [diff] [review]
1373866-pr_wp.opHead.diff

r=kaie

        Attachment #8879747 -
        Flags: review?(kaie) → review+

    
    

    
  
Please let me know if you want me to check it in.
Flags: needinfo?(dkeeler)
Keywords: checkin-needed
Target Milestone: --- → 4.16

    
    

    
  
That would be great - thanks!
Flags: needinfo?(dkeeler)

    
    

    
  
https://hg.mozilla.org/projects/nspr/rev/37643d296da1
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED

    
  
Keywords: checkin-needed

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: