1373873 - Crash in java.lang.NullPointerException: Attempt to invoke interface method ''boolean android.database.Cursor.moveToFirst()'' on a null object reference at org.mozilla.gecko.promotion.AddToHomeScreenPromotion.getHistoryForURL(AddToHomeScreenPromotion.j...

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Grisha Kruglov]

We seem to be crashing on startup while trying to track some history-related MMA event. Specifically, the code is trying to fetch history item from the database for the current url, assumes it will never get a null cursor, and crashes when said cursor _is_ null.

Comment 1

[:Grisha Kruglov]

Attachment: Bug 1373873 - Guard against a nullable cursor

Review commit: https://reviewboard.mozilla.org/r/150060/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150060/

Comment 2

[:Grisha Kruglov]

Attachment: Bug 1373873 - Post: remove unused code

Review commit: https://reviewboard.mozilla.org/r/150062/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150062/

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8878734 [details]
Bug 1373873 - Guard against a nullable cursor

https://reviewboard.mozilla.org/r/150060/#review154742

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8878735 [details]
Bug 1373873 - Post: remove unused code

https://reviewboard.mozilla.org/r/150062/#review154744

Comment 5

[Nevin Chen(Not active on Bugzilla)]

Thanks for the help!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a3738e2de59
Guard against a nullable cursor r=nechen
https://hg.mozilla.org/integration/autoland/rev/cd9b265eb8f6
Post: remove unused code r=nechen

Comment 7

[:Grisha Kruglov]

NI myself to request an uplift for this to 55.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7a3738e2de59
https://hg.mozilla.org/mozilla-central/rev/cd9b265eb8f6

Comment 9

[:Grisha Kruglov]

Attachment: startup-crash-mma-beta.patch

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1361664

[User impact if declined]: Rare startup crash

[Is this code covered by automated tests?]: no

[Has the fix been verified in Nightly?]: it's on nightly now, waiting a drop in crash-stats reports.

[Needs manual test from QE? If yes, steps to reproduce]: no

[List of other uplifts needed for the feature/fix]: n/a

[Is the change risky?]: no

[Why is the change risky/not risky?]: patch is a simple null check with some annotations added

[String changes made/needed]: n/a

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 8879274 [details] [diff] [review]
startup-crash-mma-beta.patch

fix a fennec startup crash, beta55+

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/32f08d453cfa
https://hg.mozilla.org/releases/mozilla-beta/rev/4ae19caa371f