Crash in java.lang.ClassCastException: org.mozilla.gecko.tabqueue.TabQueuePrompt cannot be cast to android.support.v4.app.FragmentActivity at org.mozilla.gecko.IntentHelper.openUriExternal(IntentHelper.java)

RESOLVED FIXED in Firefox 55

Status

()

Firefox for Android
General
--
critical
RESOLVED FIXED
10 months ago
9 months ago

People

(Reporter: Grisha, Assigned: jchen)

Tracking

({crash})

unspecified
Firefox 56
Unspecified
Android
crash
Points:
---

Firefox Tracking Flags

(fennec+, firefox54 unaffected, firefox55 fixed, firefox56 fixed)

Details

(crash signature)

Attachments

(1 attachment)

This bug was filed from the Socorro interface and is 
report bp-e423da83-56ba-4d96-9334-7c7a80170615.
=============================================================

Seems like we're making some false assumptions while processing outgoing URIs.
(Reporter)

Comment 1

10 months ago
Mike, I think you were the last one to touch this code. Do you know what could be going wrong here?
Flags: needinfo?(michael.l.comella)
(Reporter)

Updated

10 months ago
tracking-fennec: --- → ?
It looks like the changes from Bug 1363167 (d15e744f0008) are likely the cause.

Assuming this isn't urgent, forwarding to Jim who is on PTO (until the all hands?). If it's urgent, please ping me on IRC.
Blocks: 1363167
Flags: needinfo?(michael.l.comella) → needinfo?(nchen)
(Assignee)

Updated

10 months ago
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Flags: needinfo?(nchen)
(Assignee)

Comment 3

10 months ago
Created attachment 8881502 [details] [diff] [review]
Support Activities other than main Fennec Activity in openUriExternal (v1)

We may get an Activity that is not the main Fennec Activity in
IntentHelper.openUriExternal. In that case the Activity would not be a
FragmentActivity, and we should go through the fallback case. r=me for
trivial patch.
Attachment #8881502 - Flags: review+

Comment 4

10 months ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/119f62fd31af
Support Activities other than main Fennec Activity in openUriExternal; r=me

Comment 5

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/119f62fd31af
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Please request Beta approval on this when you get a chance.
status-firefox54: --- → unaffected
status-firefox55: --- → affected
Flags: needinfo?(nchen)

Updated

9 months ago
tracking-fennec: ? → +
[triage@0712] + as already fixed.
(Assignee)

Comment 8

9 months ago
Comment on attachment 8881502 [details] [diff] [review]
Support Activities other than main Fennec Activity in openUriExternal (v1)

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: Possible crash when using Firefox
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Small, one-line change that only affects the crashing condition.
[String changes made/needed]: None
Flags: needinfo?(nchen)
Attachment #8881502 - Flags: approval-mozilla-beta?
Comment on attachment 8881502 [details] [diff] [review]
Support Activities other than main Fennec Activity in openUriExternal (v1)

Crash fix, let's land this on beta.
Attachment #8881502 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 10

9 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/403291a7536f
status-firefox55: affected → fixed
You need to log in before you can comment on or make changes to this bug.