TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js | test_delayed_defaultBrowser - [test_delayed_defaultBrowser : 1586] isDefaultBrowser must be of the right type. - "object" == "boolean"

RESOLVED FIXED in Thunderbird 56.0

Status

Thunderbird
General
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Jorg K (GMT+2), Assigned: Dexter)

Tracking

Trunk
Thunderbird 56.0

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Thunderbird-testfailure: X all])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

a year ago
First seen Sat Jun 17, 2017, 8:27:05:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=e156549bd91a5036d58a7724dd386e041738cb46

TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js | xpcshell return code: 0
 
TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js | test_delayed_defaultBrowser - [test_delayed_defaultBrowser : 1586] isDefaultBrowser must be of the right type. - "object" == "boolean"

M-C last good: fe809f57bf2287bb937c3422ed03a63740
M-C first bad: bb8eab3c3ac4147848c4c85d628ba72029

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fe809f57bf2287bb937c3422ed03a63740&tochange=bb8eab3c3ac4147848c4c85d628ba72029

Caused by bug 1367029.

Maybe exclude TB here:
https://hg.mozilla.org/mozilla-central/rev/adb51b322ca8#l1.57

TB is not really a "default browser", so this test might not apply to it.

Alessio and Georg, please advise.
Flags: needinfo?(gfritzsche)
Flags: needinfo?(alessio.placitelli)
(Reporter)

Comment 1

a year ago
Created attachment 8878765 [details] [diff] [review]
1373913-default-browser-thunderbird.patch

Maybe like this.
Attachment #8878765 - Flags: review?(gfritzsche)
(Reporter)

Comment 3

a year ago
Comment on attachment 8878765 [details] [diff] [review]
1373913-default-browser-thunderbird.patch

No, that didn't work, see try, still failing.
Attachment #8878765 - Flags: review?(gfritzsche)
(Assignee)

Updated

a year ago
Assignee: nobody → alessio.placitelli
Flags: needinfo?(alessio.placitelli)
(Assignee)

Updated

a year ago
Flags: needinfo?(gfritzsche)
(Assignee)

Updated

a year ago
Blocks: 1367029
(Assignee)

Updated

a year ago
Attachment #8878765 - Attachment is obsolete: true
Comment hidden (mozreview-request)
(Assignee)

Comment 5

a year ago
Hey Jorg, this is due to the changes in bug 1367029. It includes always checking for valid values of isDefaultBrowser, while we were more relaxed before.

This patch skips the test on TB, would you mind checking that it works? If it does, I'll flag Georg for review and land it ASAP.
(Assignee)

Updated

a year ago
Flags: needinfo?(jorgk)
(Assignee)

Updated

a year ago
Status: NEW → ASSIGNED
(Reporter)

Comment 6

a year ago
Thank you for the quick response, let's see:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1d996a5d1ff9319d286b14720020ed132b0624d2
Flags: needinfo?(jorgk)
(Assignee)

Updated

a year ago
Attachment #8879028 - Flags: review?(gfritzsche)
(Assignee)

Comment 7

a year ago
(In reply to Jorg K (GMT+2) from comment #6)
> Thank you for the quick response, let's see:
> https://treeherder.mozilla.org/#/jobs?repo=try-comm-
> central&revision=1d996a5d1ff9319d286b14720020ed132b0624d2

Thank you for pushing this to try ;) Looks like the patch is working, I've flagged Georg for review.
(Reporter)

Comment 8

a year ago
Yes, working, you beat me to checking it. I made a mistake by doing a debug run, opt would have been quicker, but never mind.

Comment 9

a year ago
mozreview-review
Comment on attachment 8879028 [details]
Bug 1373913 - Skip the default browser test on Thunderbird.

https://reviewboard.mozilla.org/r/150332/#review155146

rs=me with the below addressed.

::: toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js:1572
(Diff revision 1)
>    data = TelemetryEnvironment.currentEnvironment;
>    Assert.equal(data.settings.searchCohort, "testcohort");
>  });
>  
>  add_task(async function test_delayed_defaultBrowser() {
> +  if (AppConstants.MOZ_APP_NAME == "thunderbird") {

Lets use the `skip_if` parameter for `add_task`.
Attachment #8879028 - Flags: review?(gfritzsche) → review+
Comment hidden (mozreview-request)

Comment 11

a year ago
Pushed by alessio.placitelli@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ae1a0f735603
Skip the default browser test on Thunderbird. r=gfritzsche

Comment 12

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ae1a0f735603
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 56.0
You need to log in before you can comment on or make changes to this bug.