Crash in mozilla::MediaShutdownManager::Instance

RESOLVED FIXED in Firefox 56

Status

()

Core
Audio/Video: Playback
P1
critical
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: philipp, Assigned: jwwang)

Tracking

({crash, regression})

55 Branch
mozilla56
All
Windows
crash, regression
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox54 unaffected, firefox55 wontfix, firefox56 fixed)

Details

(crash signature)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

a year ago
This bug was filed from the Socorro interface and is 
report bp-fd069750-5034-4277-adb2-539a70170617.
=============================================================
Crashing Thread (0)
Frame 	Module 	Signature 	Source
0 	xul.dll 	mozilla::MediaShutdownManager::Instance() 	dom/media/MediaShutdownManager.cpp:42
1 	xul.dll 	mozilla::MediaDecoder::Load(nsIStreamListener**) 	dom/media/MediaDecoder.cpp:626
2 	xul.dll 	mozilla::dom::HTMLMediaElement::FinishDecoderSetup(mozilla::MediaDecoder*, mozilla::MediaResource*, nsIStreamListener**) 	dom/html/HTMLMediaElement.cpp:4714
3 	xul.dll 	mozilla::dom::HTMLMediaElement::InitializeDecoderForChannel(nsIChannel*, nsIStreamListener**) 	dom/html/HTMLMediaElement.cpp:4688
4 	xul.dll 	mozilla::dom::HTMLMediaElement::MediaLoadListener::OnStartRequest(nsIRequest*, nsISupports*) 	dom/html/HTMLMediaElement.cpp:541
5 	xul.dll 	nsJARChannel::OnStartRequest(nsIRequest*, nsISupports*) 	modules/libjar/nsJARChannel.cpp:1022
6 	xul.dll 	nsInputStreamPump::OnStateStart() 	netwerk/base/nsInputStreamPump.cpp:539
7 	xul.dll 	nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream*) 	netwerk/base/nsInputStreamPump.cpp:441
8 	xul.dll 	nsInputStreamReadyEvent::Run() 	xpcom/io/nsStreamUtils.cpp:96
9 	xul.dll 	nsThread::ProcessNextEvent(bool, bool*) 	xpcom/threads/nsThread.cpp:1418
10 	xul.dll 	XPTC__InvokebyIndex 	xpcom/reflect/xptcall/md/win32/xptcinvoke_asm_x86_64.asm:97
11 		@0x0 	
12 	xul.dll 	XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) 	js/xpconnect/src/XPCWrappedNative.cpp:1282
13 	xul.dll 	XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*) 	js/xpconnect/src/XPCWrappedNativeJSOps.cpp:982
14 		@0x34e82779064 	

crash reports with this signature appear to be somewhat frequent in early data from the rollout of the 55.0b devedition. they are occurring with MOZ_RELEASE_ASSERT(sInstance) that got added in bug 1336345.
Flags: needinfo?(jwwang)
(Assignee)

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Flags: needinfo?(jwwang)
Resolution: --- → DUPLICATE
Duplicate of bug: 1366930
(Reporter)

Comment 2

a year ago
the patch for bug 1366930 landed in m-c on 2017-05-25, but the crash signature is still present in 55.0b beta now.
Flags: needinfo?(jwwang)
(Assignee)

Comment 3

a year ago
Sorry, this is not a dup.
Status: RESOLVED → REOPENED
Flags: needinfo?(jwwang)
Resolution: DUPLICATE → ---
(Assignee)

Updated

a year ago
Assignee: nobody → jwwang
Priority: -- → P1
(Assignee)

Comment 4

a year ago
I can't see how sInstance is null.

sInstance is reset in RemoveBlocker() which happens only after XPCOM shutdown begins. However, seeing Uptime is 5 sec, I don't think this is a shutdown crash.

I will add more logs for debugging.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8879421 - Flags: review?(gsquelart)
Attachment #8879422 - Flags: review?(gsquelart)
Attachment #8879423 - Flags: review?(gsquelart)

Comment 11

a year ago
mozreview-review
Comment on attachment 8879421 [details]
Bug 1373914. P1 - add a static to track the life cycle of MediaShutdownManager.

https://reviewboard.mozilla.org/r/150746/#review155530
Attachment #8879421 - Flags: review?(gsquelart) → review+

Comment 12

a year ago
mozreview-review
Comment on attachment 8879422 [details]
Bug 1373914. P2 - remove unused members.

https://reviewboard.mozilla.org/r/150748/#review155532
Attachment #8879422 - Flags: review?(gsquelart) → review+

Comment 13

a year ago
mozreview-review
Comment on attachment 8879423 [details]
Bug 1373914. P3 - dump sInitPhase when sInstance is null in Instance() to help debugging.

https://reviewboard.mozilla.org/r/150750/#review155534
Attachment #8879423 - Flags: review?(gsquelart) → review+
(Assignee)

Comment 14

a year ago
Thanks!
(Assignee)

Updated

a year ago
Keywords: leave-open

Comment 15

a year ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34bb2c8317f6
P1 - add a static to track the life cycle of MediaShutdownManager. r=gerald
https://hg.mozilla.org/integration/autoland/rev/dfb864562afe
P2 - remove unused members. r=gerald
https://hg.mozilla.org/integration/autoland/rev/22486af244c1
P3 - dump sInitPhase when sInstance is null in Instance() to help debugging. r=gerald
jw, have we learned anything since the patches have landed?
Flags: needinfo?(jwwang)
(Assignee)

Comment 18

a year ago
No. There are no new reports since the patches have landed.
Flags: needinfo?(jwwang)
Feels like we fixed it.
Status: REOPENED → RESOLVED
Last Resolved: a year agoa year ago
Resolution: --- → FIXED
status-firefox56: ? → fixed
Not sure if this is really fixed or by what - since there are no recent crashes for 55 either.
Low volume, fix-optional for 55.
status-firefox55: affected → fix-optional
Did you want to nominate this for Beta or let it ride the 56 train?
status-firefox54: --- → unaffected
status-firefox-esr52: --- → unaffected
Flags: needinfo?(jwwang)
(Assignee)

Comment 23

a year ago
No, I will let it ride the train for the patches just dump debugging info when crash happens. Maybe the code changes make the crash less frequent.
Flags: needinfo?(jwwang)
status-firefox55: fix-optional → wontfix
Keywords: leave-open
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.