1373948 - ITIP buttons should not have a transparent background

Status: RESOLVED FIXED

(Calendar :: General, enhancement)

Description

[Richard Marti (:Paenglab)]

The ITIP buttons on the light blue ITIP bar are also blue and don't really step out of the bar. We should style them like the buttons on the multimessage toolbar.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: itipButtons.patch

Use the same styling as for the multimessage toolbar.

Comment 2

[[:MakeMyDay]]

Attachment: imipbar-buttons.png

Hi Richard, I gave this a try on Windows as I stumbled accross the current situation days ago already. The combination of blue (bar) and light grey buttons without borders from the patch makes it a little hard to determine where the buttons end at a quick glance - see the attached screenshots.

The current situation on Daily is already not quite good, I assume this is a sideeffect of a change to the multimessage buttons. Compared to the style in TB 52, both are a step backwards to me.

I'm not against the (light) grey buttons (I think we had grey buttons back in 2013 iirc), but can you give the buttons a more visible border, then?

Comment 3

[Richard Marti (:Paenglab)]

Attachment: itipButtons.patch

MakeMyDay, is this better?

Comment 4

[[:MakeMyDay]]

Yes, thanks, it's better now. Sorry for the delay in response.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d63b846e2171
Give the ITIP buttons a background color. r=philipp

Comment 6

[Jorg K (CEST = GMT+2)]

Beta (TB 56, Calendar 5.8):
https://hg.mozilla.org/releases/comm-beta/rev/8aeea7d96c94eed8836cc92ef2e81b446f495259

Comment 7

[Jorg K (CEST = GMT+2)]

ESR 52.3, Calendar 5.4.3:
https://hg.mozilla.org/releases/comm-esr52/rev/425d58e45595