Closed Bug 1373948 Opened 7 years ago Closed 7 years ago

ITIP buttons should not have a transparent background

Categories

(Calendar :: General, enhancement)

Product:
Calendar
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files, 1 obsolete file)

imipbar-buttons.png
25.07 KB, image/png
Details
itipButtons.patch
5.30 KB, patch
Fallen
: review+
Fallen
: approval-calendar-beta+
Fallen
: approval-calendar-esr+
Details | Diff | Splinter Review 
The ITIP buttons on the light blue ITIP bar are also blue and don't really step out of the bar. We should style them like the buttons on the multimessage toolbar.
Attached patch itipButtons.patch (obsolete) — — Splinter Review 
Use the same styling as for the multimessage toolbar.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8878790 - Flags: review?(philipp)
Attached image imipbar-buttons.png — 
Hi Richard, I gave this a try on Windows as I stumbled accross the current situation days ago already. The combination of blue (bar) and light grey buttons without borders from the patch makes it a little hard to determine where the buttons end at a quick glance - see the attached screenshots.

The current situation on Daily is already not quite good, I assume this is a sideeffect of a change to the multimessage buttons. Compared to the style in TB 52, both are a step backwards to me.

I'm not against the (light) grey buttons (I think we had grey buttons back in 2013 iirc), but can you give the buttons a more visible border, then?
MakeMyDay, is this better?
Attachment #8878790 - Attachment is obsolete: true
Attachment #8878790 - Flags: review?(philipp)
Attachment #8878815 - Flags: review?(philipp)
Yes, thanks, it's better now. Sorry for the delay in response.
Attachment #8878815 - Flags: review?(philipp)
Attachment #8878815 - Flags: review+
Attachment #8878815 - Flags: approval-calendar-esr+
Attachment #8878815 - Flags: approval-calendar-beta+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d63b846e2171
Give the ITIP buttons a background color. r=philipp
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 5.9
ESR 52.3, Calendar 5.4.3:
https://hg.mozilla.org/releases/comm-esr52/rev/425d58e45595
Target Milestone: 5.8 → 5.4.3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: