1373969 - The overflow panel shows unnecessary scrollbars and isn't sized appropriately in some situations

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Tooru Fujisawa [:arai]]

Attachment: overflow panel overflows

Steps to reproduce:
  1. open Nightly 56.0a1 (2017-06-17) (64-bit) on OSX
  2. click hamburger button
  3. click "Customize..."
  4. add 10 items to overflow panel
  5. click "Done"
  6. click overflow panel button (">>")

Actual result:
  overflow panel has scrollbar and only partial content is displayed, even if there's more space on the panel

Expected result:
  items should be displayed as long as there's space

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1373969 - update overflow chevron state when resetting,

Review commit: https://reviewboard.mozilla.org/r/151756/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151756/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8880390 [details]
Bug 1373969 - update overflow chevron state when resetting,

Gah, wrong bug number.

Comment 3

[:Gijs (he/him)]

This is due to the fact that the scrolling container has max-height: 30em, but the panelmultiview tries to size according to content.

The max-height was added in bug 916964.

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1373969 - do scrolling correctly in overflow panel when it has a panelmultiview,

Review commit: https://reviewboard.mozilla.org/r/153988/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153988/

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8883028 [details]
Bug 1373969 - do scrolling correctly in overflow panel when it has a panelmultiview,

https://reviewboard.mozilla.org/r/153988/#review159152

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1fcfeef6615
do scrolling correctly in overflow panel when it has a panelmultiview, r=jaws

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d1fcfeef6615

Comment 8

[Md.Tarikul Islam Oashi]

I have reproduced this bug with nightly 56.0a1 (2017-06-17) on "Linux Mint (64 Bit).

The bug's fix is now verified on Latest Nightly 56.0a1

Build ID 	20170705100248
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

[Bugday-20170705]

Comment 9

[Md. Rahimul Islam]

I have successfully reproduced this bug with Nightly 56.0a1 (2017-06-17) (32-bit) on windows 10(32bit)

this bug is verified fix with  latest nightly 56.0a1 (2017-07-04) (32-bit)

Build ID: 20170704030203
Mozilla/5.0 (Windows NT 10.0; rv:56.0) Gecko/20100101 Firefox/56.0

Comment 10

[u554753]

Verified on Windows, Mac, and Ubuntu.