The overflow panel shows unnecessary scrollbars and isn't sized appropriately in some situations

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Toolbars and Customization
P1
normal
VERIFIED FIXED
2 months ago
20 days ago

People

(Reporter: arai, Assigned: Gijs)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 verified)

Details

(Whiteboard: [photon-structure])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

2 months ago
Created attachment 8878808 [details]
overflow panel overflows

Steps to reproduce:
  1. open Nightly 56.0a1 (2017-06-17) (64-bit) on OSX
  2. click hamburger button
  3. click "Customize..."
  4. add 10 items to overflow panel
  5. click "Done"
  6. click overflow panel button (">>")

Actual result:
  overflow panel has scrollbar and only partial content is displayed, even if there's more space on the panel

Expected result:
  items should be displayed as long as there's space
(Assignee)

Updated

2 months ago
Blocks: 1354086
Summary: The content of overflow panel overflows. → The overflow panel shows unnecessary scrollbars and isn't sized appropriately in some situations
Whiteboard: [photon-structure][triage]
Comment hidden (mozreview-request)
(Assignee)

Comment 2

2 months ago
Comment on attachment 8880390 [details]
Bug 1373969 - update overflow chevron state when resetting,

Gah, wrong bug number.
Attachment #8880390 - Attachment is obsolete: true
Attachment #8880390 - Flags: review?(jaws)

Updated

2 months ago
Flags: qe-verify?
Priority: -- → P2
Whiteboard: [photon-structure][triage] → [photon-structure]
(Assignee)

Updated

2 months ago
Flags: qe-verify? → qe-verify+

Updated

2 months ago
QA Contact: gwimberly
(Assignee)

Updated

2 months ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 56.2 - Jul 10
Priority: P2 → P1
(Assignee)

Comment 3

2 months ago
This is due to the fact that the scrolling container has max-height: 30em, but the panelmultiview tries to size according to content.

The max-height was added in bug 916964.
Blocks: 916964
Comment hidden (mozreview-request)

Comment 5

2 months ago
mozreview-review
Comment on attachment 8883028 [details]
Bug 1373969 - do scrolling correctly in overflow panel when it has a panelmultiview,

https://reviewboard.mozilla.org/r/153988/#review159152
Attachment #8883028 - Flags: review?(jaws) → review+

Comment 6

2 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d1fcfeef6615
do scrolling correctly in overflow panel when it has a panelmultiview, r=jaws

Comment 7

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d1fcfeef6615
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
I have reproduced this bug with nightly 56.0a1 (2017-06-17) on "Linux Mint (64 Bit).

The bug's fix is now verified on Latest Nightly 56.0a1

Build ID 	20170705100248
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

[Bugday-20170705]

Comment 9

2 months ago
I have successfully reproduced this bug with Nightly 56.0a1 (2017-06-17) (32-bit) on windows 10(32bit)

this bug is verified fix with  latest nightly 56.0a1 (2017-07-04) (32-bit)

Build ID: 20170704030203
Mozilla/5.0 (Windows NT 10.0; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [Bugday-20170705]
Verified on Windows, Mac, and Ubuntu.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
Flags: qe-verify+
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.