1374004 - ACID 3 test 23 fails with "expected '14' but got '5' - wrong exception for createElementNS('null', ':div')"

Status: NEW

(Core :: DOM: Core & HTML, defect, P3)

Description

[Tobias (:Tobbi) Markus]

Going to http://acid3.acidtests.org and running the ACID3 test, one of the failing tests is 25. 

The only thing I can see from the log is:
Test 23 failed: expected '14' but got '5' - wrong exception for createElementNS('null', ':div')

Comment 1

[Tobias (:Tobbi) Markus]

(In reply to Tobias (:Tobbi) Markus from comment #0)
> Going to http://acid3.acidtests.org and running the ACID3 test, one of the
> failing tests is 25. 

gah! This is about test #23.

Comment 2

[Tobias (:Tobbi) Markus]

For reference:

The test in question is this:

    function () {
      // test 23: createElementNS() with invalid tag names
      var test = function (name, ns, code) {
        var result;
        try {
          var div = document.createElementNS(ns, name);
        } catch (e) {
          result = e;
        }
        assert(result, "no exception for createElementNS('" + ns + "', '" + name + "')");
        assertEquals(result.code, code, "wrong exception for createElementNS('" + ns + "', '" + name + "')");
      }
      test('<div>', null, 5);
      test('0div', null, 5);
      test('di v', null, 5);
      test('di<v', null, 5);
      test('-div', null, 5);
      test('.div', null, 5);
      test('<div>', "http://example.com/", 5);
      test('0div', "http://example.com/", 5);
      test('di<v', "http://example.com/", 5);
      test('-div', "http://example.com/", 5);
      test('.div', "http://example.com/", 5);
      test(':div', null, 14);
      test(':div', "http://example.com/", 14);
      test('d:iv', null, 14);
      test('xml:test', "http://example.com/", 14);
      test('xmlns:test', "http://example.com/", 14); // (technically a DOM3 Core test)
      test('x:test', "http://www.w3.org/2000/xmlns/", 14); // (technically a DOM3 Core test)
      document.createElementNS("http://www.w3.org/2000/xmlns/", 'xmlns:test'); // (technically a DOM3 Core test)
      return 2;
    },

Comment 4

[Jessica Jong [:jessica] (inactive)]

Hi Tobias, may I know how did you get the following log?

> Test 23 failed: expected '14' but got '5' - wrong exception for createElementNS('null', ':div')

I only noticed the result is 98/100 (v54.0/Ubuntu) but did not find any error log.

Comment 5

[Tobias (:Tobbi) Markus]

(In reply to Jessica Jong [:jessica] from comment #4)
> Hi Tobias, may I know how did you get the following log?
> 
> > Test 23 failed: expected '14' but got '5' - wrong exception for createElementNS('null', ':div')
> 
> I only noticed the result is 98/100 (v54.0/Ubuntu) but did not find any
> error log.

Click the capital "A" in "Acid3" and an alert containing the errors should come up.

Comment 6

[Jessica Jong [:jessica] (inactive)]

(In reply to Tobias (:Tobbi) Markus from comment #5)
> Click the capital "A" in "Acid3" and an alert containing the errors should
> come up.

Got it, thanks!

So, it looks like test 23 and 25 failures are regressions since they fail on Nightly (today's build) but not on v54.0 release.

Comment 7

[Jessica Jong [:jessica] (inactive)]

So, with mozregression, it's caused by Bug 1358104, but looking at the bug comments, it seems that the change was intentional.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

https://github.com/whatwg/dom/issues/319#issuecomment-296345763

Comment 9

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Yes, the change was intentional and matches the spec.  If Acid3 is not updated, we should consider it obsolete.  If this causes PR problems, we should get together with the other implementers to make sure we're aligned, and possibly issue some sort of joint statement that Acid3 should be ignored.

Comment 13

[Worcester12345]

Replying here, as this seems to be the only open bug for Acid 3 test.

Out of curiosity, after some recent bugs got fixed, I went to the Acid 3 test site.

As it turned out, the current "Beta" version of Firefox does not pass the test!

Interesting.